Skip to content

fix(cli-e2e): use profileSampleConfig in profiler test builders #27947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulixius9 merged 1 commit into from
May 7, 2026
+18 −3
Merged

fix(cli-e2e): use profileSampleConfig in profiler test builders #27947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ingestion/tests/cli_e2e/base/config_builders/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ def build(self) -> dict:
self.config["source"]["sourceConfig"] = {
"config": {
"type": "Profiler",
"profileSample": self.profilerSample,
"profileSampleConfig": {
"sampleConfigType": "STATIC",
"config": {
"profileSample": self.profilerSample,
},
},
}
}

Expand Down
14 changes: 12 additions & 2 deletions ingestion/tests/cli_e2e/test_cli_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
from metadata.generated.schema.tests.basic import TestCaseResult, TestCaseStatus
from metadata.generated.schema.tests.testCase import TestCaseParameterValue
from metadata.generated.schema.type.basic import ProfileSampleType, Timestamp
from metadata.generated.schema.type.samplingConfig import (
ProfileSampleConfig,
SampleConfigType,
)
from metadata.generated.schema.type.staticSamplingConfig import StaticSamplingConfig

from .common.test_cli_db import CliCommonDB # noqa: TID252
from .common_e2e_sqa_mixins import SQACommonMethods # noqa: TID252
Expand Down Expand Up @@ -189,8 +194,13 @@ def add_table_profile_config(self):
self.openmetadata.create_or_update_table_profiler_config(
self.get_data_quality_table(),
TableProfilerConfig(
profileSampleType=ProfileSampleType.ROWS,
profileSample=100,
profileSampleConfig=ProfileSampleConfig(
sampleConfigType=SampleConfigType.STATIC,
config=StaticSamplingConfig(
profileSample=100,
profileSampleType=ProfileSampleType.ROWS,
),
),
),
)

Expand Down
Loading