Skip to content

refactor: remove embedded mode methods from router classes #28063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShaileshParmar11 wants to merge 6 commits into
base: main
Choose a base branch
from

refactor: streamline handleSettingItemClick function and improve Rout…

c7e8994
Select commit
Loading
Failed to load commit list.
Open

refactor: remove embedded mode methods from router classes #28063

refactor: streamline handleSettingItemClick function and improve Rout…
c7e8994
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / [open-metadata-ui] SonarCloud Code Analysis succeeded May 15, 2026 in 7m 19s

Quality Gate passed

Issues
1363 New issues
0 Accepted issues

Measures
17 Security Hotspots
0.0% Coverage on New Code
4.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 199 in src/utils/SSOUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQnpDV3FK4CNcumHU&open=AZ4qQnpDV3FK4CNcumHU&pullRequest=28063

Check warning on line 556 in src/components/OntologyExplorer/hooks/useOntologyGraph.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

The empty object is useless. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQi8ZV3FK4CNcumAC&open=AZ4qQi8ZV3FK4CNcumAC&pullRequest=28063

Check warning on line 171 in src/pages/EditConnectionFormPage/EditConnectionFormPage.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQlSAV3FK4CNcumDg&open=AZ4qQlSAV3FK4CNcumDg&pullRequest=28063

Check failure on line 441 in src/components/OntologyExplorer/hooks/useOntologyGraph.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Provide a compare function that depends on "String.localeCompare", to reliably sort elements alphabetically. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQi8ZV3FK4CNcumAB&open=AZ4qQi8ZV3FK4CNcumAB&pullRequest=28063

Check warning on line 134 in src/pages/AddQueryPage/AddQueryPage.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQk11V3FK4CNcumC1&open=AZ4qQk11V3FK4CNcumC1&pullRequest=28063

Check warning on line 13 in src/components/common/DeleteModal/DeleteModalMUI.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQbyPV3FK4CNcul3p&open=AZ4qQbyPV3FK4CNcul3p&pullRequest=28063

Check warning on line 87 in src/components/common/MUIAsyncTreeSelect/MUIAsyncTreeSelect.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'useTreeViewApiRef' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQbE3V3FK4CNcul2h&open=AZ4qQbE3V3FK4CNcul2h&pullRequest=28063

Check warning on line 21 in src/components/Auth/AppCallbacks/Auth0Callback/Auth0Callback.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'VFC' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQiMIV3FK4CNcul_B&open=AZ4qQiMIV3FK4CNcul_B&pullRequest=28063

Check warning on line 237 in src/components/ExploreV1/ExploreV1.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQjKqV3FK4CNcumAk&open=AZ4qQjKqV3FK4CNcumAk&pullRequest=28063

Check failure on line 107 in src/components/common/atoms/asyncTreeSelect/useTreeSelection.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQadzV3FK4CNcul1c&open=AZ4qQadzV3FK4CNcul1c&pullRequest=28063

Check warning on line 540 in src/utils/CanvasUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQmYiV3FK4CNcumFR&open=AZ4qQmYiV3FK4CNcumFR&pullRequest=28063

Check warning on line 94 in src/components/common/RichTextEditor/RichTextEditorPreviewNew.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'webkitBoxOrient' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQbf3V3FK4CNcul3E&open=AZ4qQbf3V3FK4CNcul3E&pullRequest=28063

Check warning on line 128 in src/components/common/atoms/navigation/useBreadcrumbs.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQaaYV3FK4CNcul1a&open=AZ4qQaaYV3FK4CNcul1a&pullRequest=28063

Check warning on line 1075 in src/utils/TasksUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQliFV3FK4CNcumD9&open=AZ4qQliFV3FK4CNcumD9&pullRequest=28063

Check warning on line 130 in src/components/common/UserTeamSelectableList/UserTeamSelectableList.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQcGDV3FK4CNcul3_&open=AZ4qQcGDV3FK4CNcul3_&pullRequest=28063

Check warning on line 54 in src/utils/ContainerDetailUtils.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

`newTagsFqnList` should be a `Set`, and use `newTagsFqnList.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQndxV3FK4CNcumHE&open=AZ4qQndxV3FK4CNcumHE&pullRequest=28063

Check warning on line 125 in src/components/MyData/Persona/PersonaSelectableList/PersonaSelectableList.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQeD8V3FK4CNcul6D&open=AZ4qQeD8V3FK4CNcul6D&pullRequest=28063

Check warning on line 307 in src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQZ5yV3FK4CNcul00&open=AZ4qQZ5yV3FK4CNcul00&pullRequest=28063

Check warning on line 69 in src/utils/LandingPageWidget/WidgetsUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

`scrollableValues` should be a `Set`, and use `scrollableValues.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQl-qV3FK4CNcumEb&open=AZ4qQl-qV3FK4CNcumEb&pullRequest=28063

Check warning on line 121 in src/components/Database/TableQueries/QueryCard.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQaIQV3FK4CNcul1G&open=AZ4qQaIQV3FK4CNcul1G&pullRequest=28063

Check failure on line 67 in src/components/BlockEditor/Extensions/File/FileNode.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `.dataset` over `getAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQZe8V3FK4CNcul0Z&open=AZ4qQZe8V3FK4CNcul0Z&pullRequest=28063

Check warning on line 31 in src/components/common/LeftPanelCard/LeftPanelCard.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'LeftPanelCard' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQbt1V3FK4CNcul3l&open=AZ4qQbt1V3FK4CNcul3l&pullRequest=28063

Check warning on line 176 in src/pages/Configuration/EditUrlConfiguration/EditUrlConfigurationPage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQkNfV3FK4CNcumB6&open=AZ4qQkNfV3FK4CNcumB6&pullRequest=28063

Check warning on line 248 in src/components/Database/Profiler/TestSummary/TestSummaryGraph.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Move this component definition out of the parent component and pass data as props. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQaFpV3FK4CNcul1C&open=AZ4qQaFpV3FK4CNcul1C&pullRequest=28063

Check warning on line 99 in src/components/DataQuality/SummaryPannel/SummaryPieChartCard/SummaryPieChartCard.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Do not use Array index in keys 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ4qQdc-V3FK4CNcul5g&open=AZ4qQdc-V3FK4CNcul5g&pullRequest=28063
View more details on SonarQubeCloud