test(search): integration test for marketplace index alias#28094
Closed
pmbrull wants to merge 1 commit into
Closed
test(search): integration test for marketplace index alias#28094pmbrull wants to merge 1 commit into
pmbrull wants to merge 1 commit into
Conversation
Validates that querying /v1/search/query?index=marketplace returns only Domain and DataProduct entities, scoped via the parentAliases already defined in indexMapping.json. Seeds a domain + data product + control table and confirms the table is excluded from the alias hits. Fixes open-metadata/ai-platform#578 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
Ingestion
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Comment on lines
+72
to
+86
| void marketplaceAliasReturnsOnlyDomainsAndDataProducts(TestNamespace ns) throws Exception { | ||
| OpenMetadataClient client = SdkClients.adminClient(); | ||
|
|
||
| String uniqueTag = "mp" + ns.uniqueShortId(); | ||
|
|
||
| Domain domain = createDomain(client, uniqueTag + "_domain"); | ||
| DataProduct dataProduct = createDataProduct(client, uniqueTag + "_dp", domain); | ||
| Table controlTable = createControlTable(client, ns, uniqueTag + "_table"); | ||
|
|
||
| Awaitility.await("marketplace alias returns the seeded domain and data product") | ||
| .atMost(Duration.ofSeconds(60)) | ||
| .pollDelay(Duration.ofMillis(500)) | ||
| .pollInterval(Duration.ofSeconds(1)) | ||
| .ignoreExceptions() | ||
| .untilAsserted( |
There was a problem hiding this comment.
⚠️ Quality: Test does not clean up created entities after execution
The test creates a Domain, DataProduct, DatabaseService, Database, DatabaseSchema, and Table but never deletes them. Other integration tests in this repository (e.g., EventSubscriptionResourceIT) manually call deleteEntity() or the equivalent client delete method after assertions. Without cleanup, repeated test runs or CI executions will accumulate orphan entities in the shared environment.
Suggested approach: add a try/finally block or @AfterEach to delete entities in reverse dependency order (table → schema → database → service → dataProduct → domain).
Wrap entity creation and assertions in try/finally to ensure cleanup:
@Test
void marketplaceAliasReturnsOnlyDomainsAndDataProducts(TestNamespace ns) throws Exception {
OpenMetadataClient client = SdkClients.adminClient();
String uniqueTag = "mp" + ns.uniqueShortId();
Domain domain = createDomain(client, uniqueTag + "_domain");
DataProduct dataProduct = createDataProduct(client, uniqueTag + "_dp", domain);
Table controlTable = createControlTable(client, ns, uniqueTag + "_table");
try {
Awaitility.await("marketplace alias returns the seeded domain and data product")
// ... existing await logic ...
} finally {
client.tables().delete(controlTable.getId());
client.databaseSchemas().delete(/* schema id */);
client.databases().delete(/* db id */);
client.databaseServices().delete(/* svc id */);
client.dataProducts().delete(dataProduct.getId());
client.domains().delete(domain.getId());
}
}
Was this helpful? React with 👍 / 👎
Code Review
|
| Compact |
|
Was this helpful? React with 👍 / 👎 | Gitar
Contributor
There was a problem hiding this comment.
Pull request overview
Adds backend integration coverage for the marketplace search alias to ensure it routes correctly and returns only marketplace-scoped entity types.
Changes:
- Adds
MarketplaceSearchITwith end-to-end search assertions for Domain and DataProduct results. - Seeds a control Table to verify non-marketplace entities are excluded.
- Adds a routability smoke test for the
marketplacealias.
Comment on lines
+114
to
+116
| assertFalse( | ||
| seenIds.contains(controlTable.getId().toString()), | ||
| "marketplace alias should not include tables"); |
Contributor
🔴 Playwright Results — 8 failure(s), 19 flaky✅ 4043 passed · ❌ 8 failed · 🟡 19 flaky · ⏭️ 103 skipped
Genuine Failures (failed on all attempts)❌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes open-metadata/ai-platform#578
The
marketplaceindex alias is already configured inindexMapping.jsonas aparentAliason bothdomainanddataProduct. This PR adds an integration test that pins the behavior end-to-end so the marketplace search UI cannot silently regress.Type of change:
Tests:
Use cases covered
GET /v1/search/query?index=marketplacereturns onlyDomainandDataProductentities and excludes other types (verified with a seeded controlTable).marketplacealias is routable against the live cluster without an error response.Backend integration tests
openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/MarketplaceSearchIT.javawith two tests (marketplaceAliasReturnsOnlyDomainsAndDataProducts,marketplaceAliasIsRoutableWithoutSeededData).Manual testing performed
mvn test -pl openmetadata-integration-tests -Dtest="MarketplaceSearchIT"→Tests run: 2, Failures: 0, Errors: 0, Skipped: 0.mvn -pl openmetadata-integration-tests spotless:check→ clean.UI screen recording / screenshots:
Not applicable.
Checklist:
Fixesabove.