refactor(powerbi): scope per-workspace caches to workspace lifetime

[IceS2]

Summary

• Move per-workspace state (filtered dashboards, filtered datamodels, dashboard chart mappings, dataflow exports) into a new WorkspaceState with explicit enter / exit lifecycle so caches are released between workspace iterations. The cross-workspace report registry persists so tile-pinned report-to-dashboard lineage still resolves across workspaces.
• Extract _emit_om_target_lineage shared helper used by the four create_*_lineage methods.
• Add per-workspace exception isolation: a failing workspace is logged and recorded in status.failed; the next workspace continues. Previously a single workspace error aborted the rest of the dashboard stage.
• Tighten Optional[str] handling around fqn.build() (log + skip a missing FQN before get_by_name) and fix a wrong return-type annotation on create_report_dashboard_lineage (Either[CreateDashboardRequest] -> Either[AddLineageRequest]).

Test plan

• Unit tests: cd ingestion && python -m pytest tests/unit/topology/dashboard/test_powerbi.py tests/unit/topology/dashboard/test_powerbi_workspace_state.py (59 passing locally)
• Static checks pass: cd ingestion && make static-checks (powerbi-scoped: 0 errors / 0 warnings; full-repo errors unchanged from main on Linux runner)
• Ruff: cd ingestion && ruff check src/metadata/ingestion/source/dashboard/powerbi/ && ruff format --check src/metadata/ingestion/source/dashboard/powerbi/
• End-to-end ingestion against a PowerBI instance: dashboards, datamodels, charts, and lineage (dataset->dataflow, dataset->dataset, dataflow->dataflow, tile-pinned report->dashboard) produced identically to current main.
• Verify per-workspace exception path: introduce a malformed workspace response in a test environment and confirm the run skips it and continues.

[Copilot]

Pull request overview

This PR refactors the PowerBI dashboard ingestion to scope per-workspace caches to an explicit workspace lifecycle, reducing cross-workspace state bleed and memory retention while keeping a cross-workspace report registry for tile lineage resolution. It also consolidates repeated lineage-emission logic into a shared helper and adjusts unit tests accordingly.

Changes:

• Introduce WorkspaceState with enter/exit lifecycle to manage per-workspace caches (filtered dashboards/datamodels, dashboard→chart mapping, dataflow exports) and a cross-workspace report registry.
• Add _emit_om_target_lineage helper to unify target-entity resolution + lineage emission across multiple create_*_lineage methods.
• Isolate per-workspace failures so one broken workspace is recorded/logged and subsequent workspaces continue processing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
ingestion/src/metadata/ingestion/source/dashboard/powerbi/metadata.py	Wire in WorkspaceState, add workspace-level try/finally lifecycle, and refactor lineage creation via _emit_om_target_lineage.
ingestion/src/metadata/ingestion/source/dashboard/powerbi/workspace_state.py	New workspace-scoped state container with explicit lifecycle and operation-shaped APIs for caches.
ingestion/tests/unit/topology/dashboard/test_powerbi.py	Update tests to use WorkspaceState APIs and adjust mocks for dataset lookup / dashboard chart mapping.
ingestion/tests/unit/topology/dashboard/test_powerbi_workspace_state.py	New unit tests locking the WorkspaceState lifecycle contract and cache behavior.

[gitar-bot]

Code Review ✅ Approved

Refactors PowerBI workspace state management to improve memory handling and adds per-workspace exception isolation. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqubecloud]

Quality Gate passed for 'open-metadata-ingestion'

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🟡 Playwright Results — all passed (14 flaky)

✅ 4062 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 97 skipped

Shard	Passed	Failed	Flaky	Skipped
🟡 Shard 1	298	0	1	4
🟡 Shard 2	750	0	6	19
🟡 Shard 3	783	0	1	7
🟡 Shard 4	789	0	1	18
🟡 Shard 5	708	0	1	41
🟡 Shard 6	734	0	4	8

🟡 14 flaky test(s) (passed on retry)

• Flow/Metric.spec.ts › Metric creation flow should work (shard 1, 1 retry)
• Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
• Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 2 retries)
• Features/KnowledgeCenter.spec.ts › Article mentions in description should working for Knowledge Center (shard 2, 1 retry)
• Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
• Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
• Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
• Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
• Pages/Domains.spec.ts › Domain Rbac (shard 4, 1 retry)
• Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
• Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for apiEndpoint -> table (shard 6, 1 retry)
• Pages/Lineage/LineageFilters.spec.ts › Verify Impact Analysis service filter selection (shard 6, 1 retry)
• Pages/UserDetails.spec.ts › Admin user can edit teams from the user profile (shard 6, 1 retry)
• Pages/UserDetails.spec.ts › Create team with domain and verify visibility of inherited domain in user profile after team removal (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace