Fixes 28267: Preserve test case suite search membership#28271
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes TestCase PUT updates so logical test suite membership remains present in the live search document, avoiding temporary Bundle Suite UI disappearance until reindex.
Changes:
- Hydrates
testSuiteandtestSuitesbefore TestCase update lifecycle/search indexing. - Adds a unit test for the repository hydration behavior.
- Adds an integration test that verifies PUT preserves logical suite membership in search.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java |
Hydrates suite fields before lifecycle update/search indexing. |
openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/TestCaseRepositoryTest.java |
Verifies postUpdate requests and applies suite field hydration. |
openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TestCaseResourceIT.java |
Tests logical suite membership remains in the search document after PUT. |
Code Review ✅ ApprovedUpdates the test case PUT logic to preserve test suite membership in search documents, preventing the loss of associations prior to reindexing. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
🟡 Playwright Results — all passed (10 flaky)✅ 4139 passed · ❌ 0 failed · 🟡 10 flaky · ⏭️ 89 skipped
🟡 10 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
Failed to cherry-pick changes to the 1.12.9 branch. |
|
Failed to cherry-pick changes to the 1.13 branch. |
|
|
Thanks for the PR. This needs to be updated against the latest Could you please rebase on |



Describe your changes:
Fixes #28267
I worked on preserving logical test suite membership during test case PUT updates because the live search document was losing
testSuitesuntil a full reindex.Type of change:
High-level design:
N/A - small change.
Tests:
Use cases covered
/v1/dataQuality/testCaseskeeps logical test suite membership in the test case search document.Unit tests
openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/TestCaseRepositoryTest.javaBackend integration tests
openmetadata-integration-tests/for new/changed API endpoints.openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TestCaseResourceIT.javaIngestion integration tests
Playwright (UI) tests
Manual testing performed
mvn -pl openmetadata-service -Dtest=TestCaseRepositoryTest testmvn -pl openmetadata-integration-tests -Dit.test=TestCaseResourceIT#test_putPreservesLogicalSuiteSearchMembership -DfailIfNoTests=false verifymvn -pl openmetadata-service,openmetadata-integration-tests spotless:checkmvn -pl openmetadata-service,openmetadata-integration-tests spotless:applyUI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>.Fixes #<issue-number>above.