Skip to content

Fixes 26694#28330

Merged
satender-kumar-collate merged 11 commits into
mainfrom
fix/26694
May 22, 2026
Merged

Fixes 26694#28330
satender-kumar-collate merged 11 commits into
mainfrom
fix/26694

Conversation

@satender-kumar-collate

@satender-kumar-collate satender-kumar-collate commented May 21, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #26694

I worked on ExploreV1.component.tsx to work up the stale closure in exploreLeftPanel and handled the double navigation in handleAdvanceSearchQuickFiltersChange

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Screen Recording 2026-05-21 at 1.39.41 PM

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • UI Refactor:
    • Replaced legacy antd buttons and switches in ExploreV1 with ui-core-components and Dropdown for a consistent design language.
    • Updated the explore page layout to include a refined toolbar with Export, Advanced Search, and Deleted toggles grouped under a Tools dropdown.
  • Bug fixes:
    • Fixed an export size calculation logic error where scope visibility was not being correctly evaluated.
    • Adjusted ExploreV1.test.tsx to reflect the UI component migrations and updated test interactions accordingly.
  • E2E Testing:
    • Added Playwright test cases to verify filter persistence in the explore tree and sort order preservation in the URL.

This will update automatically on new commits.

@satender-kumar-collate satender-kumar-collate requested a review from a team as a code owner May 21, 2026 08:13
@satender-kumar-collate satender-kumar-collate added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 21, 2026
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.22% (65736/103966) 43.94% (36036/82010) 46.67% (10585/22678)

@chirag-madlani chirag-madlani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add playwright test for the covering case

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (11 flaky)

✅ 4246 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 87 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
✅ Shard 2 805 0 0 8
🟡 Shard 3 791 0 5 8
🟡 Shard 4 842 0 3 12
🟡 Shard 5 717 0 2 47
🟡 Shard 6 792 0 1 8
🟡 11 flaky test(s) (passed on retry)
  • Features/OntologyExplorerCardinality.spec.ts › edges for cardinality-typed relations appear in the graph edge data (shard 3, 1 retry)
  • Features/OntologyExplorerCardinality.spec.ts › stats reflect the cardinality-typed edges in the relation count (shard 3, 1 retry)
  • Features/OntologyExplorerE2E.spec.ts › switching back from Hierarchy to Overview restores stats (shard 3, 1 retry)
  • Features/OntologyExplorerE2E.spec.ts › toggling edge labels off and back on leaves the graph and cardinality map intact (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Table (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Table (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Set (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should verify deleted glossary term not visible in selection for topic (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot

gitar-bot Bot commented May 22, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Refactors ExploreV1 UI components and resolves stale closure issues in exploreLeftPanel. No issues found.

✅ 1 resolved
Bug: exploreLeftPanel useMemo still has incomplete dependencies

📄 openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.component.tsx:403-408 📄 openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.component.tsx:415
The PR correctly adds handleQuickFiltersChange to the exploreLeftPanel useMemo dependency array to fix the stale closure for the ExploreTree callback. However, the same useMemo also references activeTabKey, loading, and onChangeSearchIndex inside its body without listing them in the dependency array (line 415). This means the Menu's selectedKeys and onClick handler can also become stale when activeTabKey changes independently of tabItems.

Since this PR is specifically fixing stale closure issues in this memo, it would be worth completing the fix for the other captured variables too.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@satender-kumar-collate satender-kumar-collate merged commit b38b386 into main May 22, 2026
48 checks passed
@satender-kumar-collate satender-kumar-collate deleted the fix/26694 branch May 22, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filters not correctly persisted in explore page

2 participants