Backport Group 2 utility extractions to 1.13#30020
Conversation
* feat(ui): extract FeedUtilsPure from FeedUtils Move 31 non-JSX functions from FeedUtils.tsx to FeedUtilsPure.ts. FeedUtils.tsx re-exports all moved symbols for backward compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix checkstyle --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* feat(ui): extract TablePureUtils and TagsPureUtils Move 43 pure functions from TableUtils.tsx to TablePureUtils.ts and 5 functions from TagsUtils.tsx to TagsPureUtils.ts. Both original files re-export all moved symbols for backward compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix checkstyle --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
…lityPureUtils (#28701) * feat(ui): extract DataProductPureUtils, DataInsightPureUtils, DataQualityPureUtils Move pure (no-JSX, no-API, no-singleton) functions from DataProductUtils.tsx, DataInsightUtils.tsx, and DataQualityUtils.tsx into dedicated *PureUtils.ts files. Originals re-export all moved symbols for backward compat. - DataProductPureUtils.ts: convertDataProductsToEntityReferences, convertEntityReferencesToDataProducts, getQueryFilterForDataProductPorts - DataInsightPureUtils.ts: getEntryFormattedValue, getGraphDataByEntityType, getFormattedActiveUsersData, getDisabledDates, getDataInsightPathWithFqn, getOptionalDataInsightTabFlag, sortEntityByValue, getRandomHexColor, isPercentageSystemGraph, getQueryFilterForDataInsightChart (+ 3 private helpers) - DataQualityPureUtils.ts: 27 symbols including buildTestCaseParams, createUpdatedTestCasePatch, buildDataQualityDashboardFilters, getDimensionIcon, calculateTestCaseStatusCounts, transformToTestCaseStatusByDimension, etc. All type-only imports use import type. 78 existing tests still pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore(ui): apply prettier formatting to PR7 pure utils files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* feat(ui): extract pure service utils and widget components Extract 26 pure functions from ServiceUtils.tsx, ServiceInsightsTabUtils.tsx, and DatabaseServiceUtils.tsx into dedicated pure util modules. Promote getServiceInsightsWidgetPlaceholder to standalone component file. All original files re-export moved symbols for backward compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix checkstyle --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
… components (#28687) * feat(ui): extract EntityVersion/Diff pure utils and lazy-load version components Split monolithic EntityVersionUtils.tsx (~1420 lines) into focused modules: - EntityDiffPureUtils.ts: pure diff accessor functions (no React deps) - EntityDiffUtils.tsx: JSX diff rendering functions - EntityVersionUtilsPure.ts: pure version processing logic - EntityVersionClassBase.ts: lazy-load registry for version components EntityVersionUtils.tsx re-exports all symbols for backward compatibility. EntityVersionPage now uses lazy-loaded components via EntityVersionClassBase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(ui): replace ComponentType<any> with typed VersionComponentType in EntityVersionClassBase Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix checkstyle * fix(pr5): convert type-only imports to import type across all changed files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix checkstyle --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
🟡 Playwright Results — all passed (1 flaky)✅ 290 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 4 skipped
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Code Review ✅ Approved 3 resolved / 3 findingsBackports Group 2 utility extractions to 1.13, resolving import discrepancies and aligning API contracts for feed and versioning logic. No issues found. ✅ 3 resolved✅ Bug: Backport imports APIs/types that don't exist in 1.13
✅ Performance: fetchEntityTaskCountsInto fetches all feed counts unfiltered
✅ Bug: Dead else branch: getFeedCount always returns an array
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|



Summary
Testing
Greptile Summary
This PR backports utility extraction work for the 1.13 UI branch. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (6): Last reviewed commit: "fix(ui): scope feed count helpers for 1...." | Re-trigger Greptile
Context used (3)