refactor: om_decoder_next_data_read#19
Draft
terraputix wants to merge 6 commits into
Draft
Conversation
This was referenced Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted a function
om_decoder_get_lut_valuefromom_decoder_next_data_read.On the hand I think this makes the
om_decoder_next_data_readsignificantly easier to read and understand. On the other hand, I think it is useful for extracting the complete LUT (which might be useful for kerchunking). Consider this a Draft for the moment, until the discussion in fsspec/kerchunk#464 is resolved.