[Feature] Add OneMinusNormEditDistance for OCR Task#95
Open
Harold-lkk wants to merge 6 commits into
Open
Conversation
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
from
eba0ab8 to
0a299c5
Compare
C1rN09
reviewed
Feb 16, 2023
Collaborator
C1rN09
left a comment
C1rN09
left a comment
There was a problem hiding this comment.
LGTM with some comments! Also please add the api docs.
C1rN09
reviewed
Feb 17, 2023
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
from
dda766e to
b7e8395
Compare
C1rN09
reviewed
Feb 28, 2023
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
from
b7e8395 to
412c681
Compare
C1rN09
reviewed
Mar 2, 2023
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
2 times, most recently
from
823bf0e to
1439ed3
Compare
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
from
1439ed3 to
8781329
Compare
C1rN09
approved these changes
Mar 9, 2023
Collaborator
C1rN09
left a comment
C1rN09
left a comment
There was a problem hiding this comment.
LGTM. Should rebase to main to pass CI
Harold-lkk
force-pushed
the
lkk/OneMinusNormEditDistance
branch
from
8781329 to
dbeb3ea
Compare
zhouzaida
reviewed
Mar 14, 2023
| invalid_symbol: str = '[^A-Za-z0-9\u4e00-\u9fa5]', | ||
| **kwargs): | ||
| super().__init__(**kwargs) | ||
|
|
Collaborator
There was a problem hiding this comment.
rapidfuzz is not added in runtime.txt so the metric will throw an error when calling add method. The solution is to check it in __init__. Refer to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt at open-mmlab/mmocr#1728