Adapt datapackage export for storage

Author: Bachibouzouk

app/projects/models/base_models.py

@@ -318,7 +318,7 @@ def export(self, bind_project_data=False):
     def to_datapackage(self, destination_path):
 
         # Create a folder with a datapackage structure
-        scenario_folder = destination_path / f"scenario_{self.id}"
+        scenario_folder = destination_path / f"scenario_{self.name}".replace(" ", "_")
 
         data_folder = scenario_folder / "data"
         elements_folder = data_folder / "elements"
@@ -338,9 +338,11 @@ def to_datapackage(self, destination_path):
 
         # List all components of the scenario (except the busses)
         qs_assets = Asset.objects.filter(scenario=self)
-        # List all distinct components' assettypes (or facade name)
-        facade_names = qs_assets.distinct().values_list(
-            "asset_type__asset_type", flat=True
+        # List all distinct components' assettypes (or facade name) which are not children
+        facade_names = (
+            qs_assets.filter(parent_asset__isnull=True)
+            .distinct()
+            .values_list("asset_type__asset_type", flat=True)
         )
 
         bus_resource_records = []
@@ -395,7 +397,7 @@ def to_datapackage(self, destination_path):
 
         # creating datapackage.json metadata file at the root of the datapackage
         building.infer_metadata_from_data(
-            package_name=f"scenario_{self.id}",
+            package_name=f"scenario_{self.name}".replace(" ", "_"),
             path=scenario_folder,
             fk_targets=["project"],
         )
@@ -775,21 +777,66 @@ def to_datapackage(self):
             dp["project_data"] = self.scenario.project.name
         # to collect the timeseries used by the asset
         profile_resource_rec = {}
-        for field in self.asset_type.visible_fields:
-            value = getattr(self, field)
-            # if the field is a candidate for a scalar/list
-            if isinstance(value, str) and field != "name":
-                value = json.loads(value)
-                if isinstance(value, list):
-                    col = f"{self.name}__{field}"
-                    profile_resource_rec[col] = value
+
+        # Storage assets are the only one to have children (namely `capacity`, `charge` and `discharge`
+        qs_children = Asset.objects.filter(parent_asset__id=self.id)
+        if qs_children.exists():
+            # Only keep the values from the capacity children asset of the storage
+            capacity = qs_children.get(asset_type__asset_type="capacity")
+            for attribute in [
+                "capex_fix",
+                "capex_var",
+                "opex_fix",
+                "opex_var",
+                "lifetime",
+                "crate",
+                "efficiency",
+                "soc_max",
+                "soc_min",
+                "maximum_capacity",
+                "optimize_cap",
+                "installed_capacity",
+                "age_installed",
+                "thermal_loss_rate",  # only for hess
+                "fixed_thermal_losses_relative",  # only for hess
+                "fixed_thermal_losses_absolute",  # only for hess
+            ]:
+                setattr(self, attribute, getattr(capacity, attribute))
+
+            if self.asset_type.asset_type != "hess":
+                attributes = [
+                    f
+                    for f in AssetType.objects.get(asset_type="capacity").visible_fields
+                    if f
+                    not in (
+                        "thermal_loss_rate",
+                        "fixed_thermal_losses_relative",
+                        "fixed_thermal_losses_absolute",
+                    )
+                ]
+            else:
+                attributes = AssetType.objects.get(asset_type="capacity").visible_fields
+        else:
+            attributes = self.asset_type.visible_fields
+
+        for field in attributes:
+            if (
+                field != "dispatchable"
+            ):  # TODO remove this when `dispatchable` not a visible field anymore
+                value = getattr(self, field)
+                # if the field is a candidate for a scalar/list
+                if isinstance(value, str) and field != "name":
+                    value = json.loads(value)
+                    if isinstance(value, list):
+                        col = f"{self.name}__{field}"
+                        profile_resource_rec[col] = value
+                        value = col
+                elif isinstance(value, Timeseries):
+                    col = value.name
+                    profile_resource_rec[col] = value.values
                     value = col
-            elif isinstance(value, Timeseries):
-                col = value.name
-                profile_resource_rec[col] = value.values
-                value = col
 
-            dp[field] = value
+                dp[field] = value
 
         # to collect the bus(ses) used by the asset
         bus_resource_rec = []
@@ -807,7 +854,6 @@ def to_datapackage(self):
                 qs_bus = self.connectionlink_set.filter(
                     flow_direction=direction, asset_connection_port=port
                 )
-                # TODO use bus names for the resource column label according to a convention with the facade attributes
                 if qs_bus.exists():
                     connection = qs_bus.get()
                     dp[field] = connection.bus.name