Extract memory validation into common function for processor modes#942
Extract memory validation into common function for processor modes#942spoorthys1303 wants to merge 1 commit into
Conversation
Changes: - Added validate_and_adjust_memory() method to LparConfig class - Validates and adjusts memory values to ensure min <= desired <= max - Maintains consistent validation behavior across both processor modes - Logs warnings when memory values are automatically adjusted Signed-off-by: Spoorthy S <spoorts2@in.ibm.com>
a739b75 to
3fdbc77
Compare
|
@PraveenPenguin fix for the memory allocation , Please review the PR |
|
@spoorthys1303 is this the fix for the problem, where the memory layout for lpar is changed. after setting min and max ? |
|
@abdhaleegit issue in assigning memory was observed in ProfileSetup where max , desired memory is not mentioned in the config |
|
one situation where this script will set min_mem=4096,desired_mem=40960,max_mem=23552 .. min and default memory are default value coded in the script and max memory is calculated from available memory , and we get error that desired is greater than max and script will fail.. so this logic will make sure min<desired<max |
|
@PraveenPenguin should we handle how maximum memory is calculated from available memory and the steal able memory ? |
Having maximum memory is calculated from available memory should be ok |
|
@spoorthys1303 @PraveenPenguin if I have lets say max memory set for lpar as 30GB,, and when run with CR with this patch.. I want the max 30GB to be intact... and not worry about min and desired memory ? thats the CR concern I had.. all CR lpars were changed to max available memory.. will this patch fix this ? |
Changes: