Skip to content

Add kyberslash patches for valgrind-based constant-time testing#106

Merged
bhess merged 1 commit into
open-quantum-safe:mainfrom
pablo-gf:main
Jun 23, 2026
Merged

Add kyberslash patches for valgrind-based constant-time testing#106
bhess merged 1 commit into
open-quantum-safe:mainfrom
pablo-gf:main

Conversation

@pablo-gf

Copy link
Copy Markdown
Contributor

This PR includes Valgrind's Kyberslash patch for the ubuntu-latest container so that the constant-time tooling framework from PR #2449 can be included in CI, as discussed in a previous status call.

Let me know if you have any comments or suggestions before moving it to ready for review!

Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>

@baentsch baentsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image meant to completely replace the valgrind build in the liboqs PR? If I'm not mistaken, that one's matrixed on the compiler, but I don't see this here: Intentional?

@pablo-gf

pablo-gf commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the comment @baentsch. Yes, this image completely replaces the building process of the kyberslash-patched Valgrind in the liboqs PR. The matrix compiler (gcc vs clang) is only used to build and test liboqs (not Valgrind) via the ./ct_test.sh script. In the original workflow, the Valgrind build step didn't actually reference the matrix compiler, so Valgrind itself was already being built with the default system compiler.

The idea is that the container will directly include the Kyberslash-patched version of Valgrind, and we can execute the CT tests directly calling valgrind_varlat following the architecture set by the job's matrix (compiler, liboqs build, optimization flag).

Hope that clarifies it, but maybe I misunderstood your comment. Please let me know if that's the case.

@baentsch

Copy link
Copy Markdown
Member

Hope that clarifies it

It does. Then this PR LGTM. Thanks for streamlining things, @pablo-gf

@pablo-gf pablo-gf marked this pull request as ready for review June 23, 2026 13:10

@bhess bhess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhess bhess merged commit db3b698 into open-quantum-safe:main Jun 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants