Add kyberslash patches for valgrind-based constant-time testing#106
Conversation
Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>
baentsch
left a comment
There was a problem hiding this comment.
Is this image meant to completely replace the valgrind build in the liboqs PR? If I'm not mistaken, that one's matrixed on the compiler, but I don't see this here: Intentional?
|
Thanks for the comment @baentsch. Yes, this image completely replaces the building process of the kyberslash-patched Valgrind in the liboqs PR. The matrix compiler (gcc vs clang) is only used to build and test liboqs (not Valgrind) via the The idea is that the container will directly include the Kyberslash-patched version of Valgrind, and we can execute the CT tests directly calling Hope that clarifies it, but maybe I misunderstood your comment. Please let me know if that's the case. |
It does. Then this PR LGTM. Thanks for streamlining things, @pablo-gf |
This PR includes Valgrind's Kyberslash patch for the ubuntu-latest container so that the constant-time tooling framework from PR #2449 can be included in CI, as discussed in a previous status call.
Let me know if you have any comments or suggestions before moving it to ready for review!