SHA3 test improvements#2450
Open
mdcornu wants to merge 4 commits into
Open
Conversation
Move msg0, msg24, msg448, msg896, and msg1600 from local declarations repeated in each of the seven test functions into static const globals. Signed-off-by: Cornu, Marcel D <marcel.d.cornu@intel.com>
…idation Add 896-bit NIST vector and cross-validate inc API against one-shot API. Signed-off-by: Cornu, Marcel D <marcel.d.cornu@intel.com>
Cross-validate SHAKE inc API against one-shot using absorb and squeeze sweep, covering all code paths and rate-boundary transitions. Add distinct x4 lane inputs to the four-way tests. Signed-off-by: Cornu, Marcel D <marcel.d.cornu@intel.com>
Signed-off-by: Cornu, Marcel D <marcel.d.cornu@intel.com>
|
Coverage is 82.183% — mdcornu:tests/improve_sha3_test into open-quantum-safe:main. No base build found for |
Contributor
|
Thank you for the test enhancements! These are much needed for the less battle-tested implementations. I will review this first thing after 0.16.0-rc1 release. |
Contributor
Author
No problem, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
tests/test_sha3.cwith broader coverage and reduce vector duplication.As per discussion on recent PR #2442:
This code was partially generated using an AI coding assistant (GitHub Copilot - model: Claude Sonnet 4.6), but manually reviewed and verified before submission.