Add parantheses around the use of sizeof operator#2471
Open
Hussain1811 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sadiq Hussain M <Sadiq.Hussain.M@ibm.com>
|
coverage: 85.793% (+3.5%) from 82.3% — Hussain1811:add_parantheses into open-quantum-safe:main |
Hussain1811
requested review from
ashman-p,
bhess,
cothan and
xuganyu96
as code owners
bhess
reviewed
Jun 25, 2026
bhess
left a comment
bhess
left a comment
Member
There was a problem hiding this comment.
AFAIK parentheses after sizeof are optional in C if the argument is not a type. Did you encounter any formatting issues in practice because of this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a formatting issue with the use of the sizeof operator.
Basically surrounding the use of sizeof operator with parantheses.
Checklist
Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)?
No. This PR just addresses a code formatting issue.
Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API?
No. This PR just addresses a code formatting issue.