tests: Mark rc as public via declassification#2473
Open
Hussain1811 wants to merge 1 commit into
Open
Conversation
Without the declassify call, Valgrind would report a false positive — flagging the if (rc != OQS_SUCCESS) check as secret-dependent control flow, when in reality the return code is intentionally a public value. Signed-off-by: Sadiq Hussain M <Sadiq.Hussain.M@ibm.com>
|
Coverage is 82.294% — Hussain1811:declassify_after_api_call into open-quantum-safe:main. No base build found for |
Hussain1811
requested review from
ashman-p,
bhess,
cothan and
xuganyu96
as code owners
bhess
approved these changes
Jun 25, 2026
bhess
left a comment
bhess
left a comment
Member
There was a problem hiding this comment.
Thanks for the improvements @Hussain1811, LGTM.
It seems that since we currently don't CT-test the stfl signatures and the extended tests didn't pop up as a false positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Without the declassify call, Valgrind would report a false positive — flagging the if (rc != OQS_SUCCESS) check as secret-dependent control flow, when in reality the return code is intentionally a public value.
Checklist
Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)?
No
Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API?
No