Skip to content

tests: Mark rc as public via declassification #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hussain1811 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

tests: Mark rc as public via declassification #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_sig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ static OQS_STATUS sig_test_correctness(const char *method_name, bool bitflips_al
}
} else if (extended_tests) {
rc = OQS_SIG_sign_with_ctx_str(sig, signature, &signature_len, message, message_len, ctx, 1, secret_key);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_ERROR) {
fprintf(stderr, "ERROR: OQS_SIG_sign_with_ctx_str should fail without support for context strings\n");
goto err;
Expand Down
14 changes: 11 additions & 3 deletions tests/test_sig_stfl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ static OQS_STATUS sig_stfl_test_secret_key(const char *method_name, const char *
printf("================================================================================\n");

rc = sig_stfl_KATs_keygen(sig_obj, public_key, sk, katfile);

OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key gen failed.\n");
goto err;
Expand All @@ -718,12 +718,14 @@ static OQS_STATUS sig_stfl_test_secret_key(const char *method_name, const char *
* Get max num signature and the amount remaining
*/
rc = OQS_SIG_STFL_sigs_total((const OQS_SIG_STFL *)sig_obj, &max_num_sigs, (const OQS_SIG_STFL_SECRET_KEY *)sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get max number of sig from %s.\n", method_name);
goto err;
}

rc = OQS_SIG_STFL_sigs_remaining((const OQS_SIG_STFL *)sig_obj, &num_sig_left, (const OQS_SIG_STFL_SECRET_KEY *)sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get the remaining number of sig from %s.\n", method_name);
goto err;
Expand Down Expand Up @@ -769,7 +771,7 @@ static OQS_STATUS sig_stfl_test_secret_key(const char *method_name, const char *

context_2 = strdup(file_store_name);
rc = OQS_SIG_STFL_SECRET_KEY_deserialize(sk_from_file, from_file_sk_buf, from_file_sk_len, (void *)context_2);

OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS restore %s from file failed.\n", method_name);
goto err;
Expand Down Expand Up @@ -892,12 +894,14 @@ static OQS_STATUS sig_stfl_test_sig_gen(const char *method_name) {
*/
unsigned long long num_sig_left = 0, max_num_sigs = 0;
rc = OQS_SIG_STFL_sigs_total((const OQS_SIG_STFL *)lock_test_sig_obj, &max_num_sigs, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get max number of sig from %s.\n", method_name);
goto err;
}

rc = OQS_SIG_STFL_sigs_remaining((const OQS_SIG_STFL *)lock_test_sig_obj, &num_sig_left, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get the remaining number of sig from %s.\n", method_name);
goto err;
Expand All @@ -921,12 +925,14 @@ static OQS_STATUS sig_stfl_test_sig_gen(const char *method_name) {
*/
num_sig_left = 0, max_num_sigs = 0;
rc = OQS_SIG_STFL_sigs_total((const OQS_SIG_STFL *)lock_test_sig_obj, &max_num_sigs, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get max number of sig from %s.\n", method_name);
goto err;
}

rc = OQS_SIG_STFL_sigs_remaining((const OQS_SIG_STFL *)lock_test_sig_obj, &num_sig_left, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get the remaining number of sig from %s.\n", method_name);
goto err;
Expand Down Expand Up @@ -954,12 +960,14 @@ static OQS_STATUS sig_stfl_test_sig_gen(const char *method_name) {
*/
num_sig_left = 0, max_num_sigs = 0;
rc = OQS_SIG_STFL_sigs_total((const OQS_SIG_STFL *)lock_test_sig_obj, &max_num_sigs, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get max number of sig from %s.\n", method_name);
goto err;
}

rc = OQS_SIG_STFL_sigs_remaining((const OQS_SIG_STFL *)lock_test_sig_obj, &num_sig_left, (const OQS_SIG_STFL_SECRET_KEY *)lock_test_sk);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key: Failed to get the remaining number of sig from %s.\n", method_name);
goto err;
Expand Down Expand Up @@ -1019,7 +1027,7 @@ static OQS_STATUS sig_stfl_test_secret_key_lock(const char *method_name, const c
printf("================================================================================\n");

rc = sig_stfl_KATs_keygen(lock_test_sig_obj, lock_test_public_key, lock_test_sk, katfile);

OQS_TEST_CT_DECLASSIFY(&rc, sizeof(rc));
if (rc != OQS_SUCCESS) {
fprintf(stderr, "OQS STFL key gen failed.\n");
goto err;
Expand Down
Loading