Skip to content

Update Kearnes affiliation and remove unreachable about.html#209

Merged
skearnes merged 1 commit into
open-reaction-database:mainfrom
skearnes:update-affiliation-remove-dead-about-html
Jul 10, 2026
Merged

Update Kearnes affiliation and remove unreachable about.html#209
skearnes merged 1 commit into
open-reaction-database:mainfrom
skearnes:update-affiliation-remove-dead-about-html

Conversation

@skearnes

@skearnes skearnes commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

Two related changes to the about page.

Affiliation fix. The Governance Board list rendered Steven Kearnes (Relay). #162 corrected this to Genesis in ord_interface/about.html, but the Vue-to-React migration (#179) landed afterward and rebuilt the page from an older source, reintroducing the stale affiliation. The React page has shown the outdated value since then.

Dead file removal. ord_interface/about.html is unreachable in the deployed image:

  • nginx serves location / from /app/ord-interface/spa, while the Dockerfile copied the file to /app/ord-interface/ord_interface/ — outside the served root.
  • The Flask app registers exactly one route, /ketcher; nothing renders the template.
  • No link to it exists anywhere in app/, docs/, or the Dockerfile beyond the COPY itself.

The file and its COPY directive are removed. A repo-wide grep for about.html now returns nothing.

Testing

  • npm run build succeeds; the compiled bundle contains Steven Kearnes (Genesis).
  • Pre-commit hooks (addlicense, ty, prettier) pass.

🤖 Generated with Claude Code

Greptile Summary

This PR updates the About page content and removes an unused legacy HTML file.

  • Changes Steven Kearnes' React About page affiliation to Genesis.
  • Removes the legacy ord_interface/about.html file.
  • Removes the Docker copy step for that deleted file.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
app/src/views/About.tsx Updates one static affiliation entry on the React About page.
ord_interface/Dockerfile Removes the copy step for the deleted legacy About HTML file.
ord_interface/about.html Deletes the legacy standalone About page that is not used by the deployed /about route.

Reviews (1): Last reviewed commit: "Update Kearnes affiliation and remove un..." | Re-trigger Greptile

The React about page listed "Steven Kearnes (Relay)". open-reaction-database#162 corrected this
to Genesis in ord_interface/about.html, but the Vue-to-React migration
(open-reaction-database#179) rebuilt the page from an older source and reintroduced the stale
affiliation.

ord_interface/about.html is unreachable: nginx serves / from
/app/ord-interface/spa, the Dockerfile copied the file to
/app/ord-interface/ord_interface/, and the Flask app exposes only
/ketcher. Nothing links to it. Drop the file and its COPY directive.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@skearnes skearnes merged commit 8cafe29 into open-reaction-database:main Jul 10, 2026
16 checks passed
@skearnes skearnes deleted the update-affiliation-remove-dead-about-html branch July 10, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant