general code cleanup

Author: open-risk

.vscode/launch.json

@@ -1,7 +1,4 @@
 {
-    // Use IntelliSense to learn about possible attributes.
-    // Hover to view descriptions of existing attributes.
-    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
         {

CODE_OF_CONDUCT.md

@@ -12,7 +12,7 @@ If you believe someone is violating the code of conduct, we ask that you report
 
 - **Be friendly and patient.**
 - **Be welcoming.** We strive to be a community that welcomes and supports people of all backgrounds and identities. This includes, but is not limited to members of any race, ethnicity, culture, national origin, colour, immigration status, social and economic class, educational level, sex, sexual orientation, gender identity and expression, age, size, family status, political belief, religion, and mental and physical ability.
-- **Be considerate.** Your work will be used by other people, and you in turn will depend on the work of others. Any decision you take will affect users and colleagues, and you should take those consequences into account when making decisions. Remember that we're a world-wide community, so you might not be communicating in someone else's primary language.
+- **Be considerate.** Your work will be used by other people, and you in turn will depend on the work of others. Any decision you take will affect users and colleagues, and you should take those consequences of account when making decisions. Remember that we're a world-wide community, so you might not be communicating in someone else's primary language.
 - **Be respectful.** Not all of us will agree all the time, but disagreement is no excuse for poor behavior and poor manners. We might all experience some frustration now and then, but we cannot allow that frustration to turn into a personal attack. It’s important to remember that a community where people feel uncomfortable or threatened is not a productive one. Members of the OpenNPL community should be respectful when dealing with other members as well as with people outside the OpenNPL community.
 - **Be careful in the words that you choose.** We are a community of professionals, and we conduct ourselves professionally. Be kind to others. Do not insult or put down other participants. Harassment and other exclusionary behavior aren't acceptable. This includes, but is not limited to: 
  - Violent threats or language directed against another person.

SECURITY.md

@@ -5,7 +5,7 @@
 Use this section to tell people about which versions of your project are currently being supported with security updates.
 
 | Version | Supported          |
-| ------- | ------------------ |
+|---------|--------------------|
 | 5.1.x   | :white_check_mark: |
 | 5.0.x   | :x:                |
 | 4.0.x   | :white_check_mark: |

dashboard.py

@@ -6,14 +6,14 @@ services:
     working_dir: /opennpl
     command: python manage.py runserver 0.0.0.0:8080
     ports:
-      - 8080:8080
+      - "8080:8080"
     env_file:
       - ./.env.dev
   postgres:
     build: ./docker/postgres
     working_dir: /opennpl
     command: python manage.py runserver 0.0.0.0:8081
     ports:
-      - 8081:8081
+      - "8081:8081"
     env_file:
       - ./.env.dev

docker-compose.yml

@@ -112,7 +112,7 @@ class SFLP_LoanSerializer(serializers.ModelSerializer):
 
     class Meta:
         model = Loan
-        fields = ('id', 'contract_identifier', 'link')
+        fields = ('id', 'loan_identifier', 'link')
 
     def get_link(self, obj):
         link = ROOT_VIEW + "/api/SFLP_data/loans/" + str(obj.pk)
@@ -133,7 +133,7 @@ class SFLP_PropertyCollateralSerializer(serializers.ModelSerializer):
 
     class Meta:
         model = PropertyCollateral
-        fields = ('id', 'protection_identifier', 'link')
+        fields = ('id', 'loan_identifier', 'link')
 
     def get_link(self, obj):
         link = ROOT_VIEW + "/api/SFLP_data/property_collateral/" + str(obj.pk)

openNPL/sflp_serializers.py

@@ -46,6 +46,7 @@
                   path('admin/doc/', include('django.contrib.admindocs.urls')),  #
                   path('admin/', admin.site.urls),
                   path('', include('start.urls')),  # start URLS
+                  path('markdownfield/', include('markdownfield.urls')),
                   path(r'api/', api_root, name='api_root'),  # Overall API root
                   # NPL Data URL's
                   path(r'api/npl_data/', include(('npl_portfolio.urls', 'npl_portfolio'), namespace='npl_portfolio')),

openNPL/urls.py

@@ -80,7 +80,7 @@ class Command(BaseCommand):
 
     loan_dict = {}
     for index, entry in loan_data.iterrows():
-        if (i < LOAN_COUNT):
+        if i < LOAN_COUNT:
             loan = Loan.objects.create(
                 id=i,
                 loan_identifier=entry[0],

sflp_portfolio/management/commands/load_static_sflp_csv.py

@@ -1,3 +1,4 @@
+@charset "UTF-8";
 /*
  * This combined file was created by the DataTables downloader builder:
  *   https://datatables.net/download
@@ -10,7 +11,6 @@
  *   DataTables 1.11.5, Responsive 2.2.9
  */
 
-@charset "UTF-8";
 table.dataTable th.dt-left,
 table.dataTable td.dt-left {
   text-align: left;
@@ -118,7 +118,6 @@ table.dataTable {
 }
 table.dataTable td,
 table.dataTable th {
-  -webkit-box-sizing: content-box;
   box-sizing: content-box;
 }
 table.dataTable td.dataTables_empty,
@@ -460,7 +459,6 @@ div.dtr-modal div.dtr-modal-display {
   overflow: auto;
   margin: auto;
   z-index: 102;
-  overflow: auto;
   background-color: #f5f5f7;
   border: 1px solid black;
   border-radius: 0.5em;