Skip to content

fix: QoS mismatch in tests#28

Merged
xiyuoh merged 2 commits into
epic/next-gen-basefrom
arjoc/fix/qos_mismatch_tests
Jul 3, 2026
Merged

fix: QoS mismatch in tests#28
xiyuoh merged 2 commits into
epic/next-gen-basefrom
arjoc/fix/qos_mismatch_tests

Conversation

@arjo129

@arjo129 arjo129 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Bug fix

Fixed bug

Our CI has been flaky as our tests have mismatched QoS expectations and if tests are run in parrallel they also may interfere with each other.

Fix applied

  • Match QoS ti be transient local on the python side as well.
  • Sequentially execute the tests so that they dont interfere with each other.

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: Gemini

arjo129 added 2 commits July 3, 2026 05:58
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@mxgrey mxgrey added this to PMC Board Jul 3, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board Jul 3, 2026
@arjo129
arjo129 requested a review from xiyuoh July 3, 2026 06:07
@arjo129 arjo129 changed the title Arjoc/fix/qos mismatch tests fix: QoS mismatch in tests Jul 3, 2026

@xiyuoh xiyuoh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@xiyuoh
xiyuoh merged commit 512b83e into epic/next-gen-base Jul 3, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in PMC Board Jul 3, 2026
@xiyuoh
xiyuoh deleted the arjoc/fix/qos_mismatch_tests branch July 3, 2026 06:30
SamuelFoo pushed a commit to SamuelFoo/next_gen_prototype that referenced this pull request Jul 9, 2026
* Fix QoS durability mismatches in integration tests

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

* CI: Run tests sequentially to avoid DDS interference

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

---------

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants