Submit bid as long as fleet name exists (in string or array)#534
Open
lttey wants to merge 1 commit into
Open
Conversation
Member
Signed-off-by: lttey <leong_teck_tey@cgh.com.sg>
lttey
force-pushed
the
feat/task_to_fleets
branch
from
July 9, 2026 06:22
cb8b1b7 to
7aeb92d
Compare
Contributor
Author
|
@xiyuoh thanks. Have signed off and forced pushed for the repo as well as PR at rmf_api_msgs. Have updated AI model above as well. |
mxgrey
reviewed
Jul 17, 2026
mxgrey
left a comment
Contributor
There was a problem hiding this comment.
The code looks good.
@cardboardcode could you run some manual tests of this branch along with open-rmf/rmf_api_msgs#64 and verify that a dispatch request that contains an array of fleet names is handled correctly? I would expect the following:
- Empty array means no fleet is selected
- Array with many names but no matching fleets means no fleet is selected
- Array with many names and one match means the matching fleet is selected
- Array with many names and multiple matching fleets means the most available fleet is selected (the hotel world demo can be used for this)
- A string (instead of an array) means the fleet with that name is selected
- Anything other than a string or array (e.g. a number) means the bid request fails
- Under no circumstance is there a crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
refer to feature request
Implementation description
Beside checking whether fleet name fully match in entire string, it shall be able to check also whether exist in string array. Another iteration is added.
GenAI Use
We follow OSRA's policy on GenAI tools