Skip to content

Submit bid as long as fleet name exists (in string or array)#534

Open
lttey wants to merge 1 commit into
open-rmf:mainfrom
lttey:feat/task_to_fleets
Open

Submit bid as long as fleet name exists (in string or array)#534
lttey wants to merge 1 commit into
open-rmf:mainfrom
lttey:feat/task_to_fleets

Conversation

@lttey

@lttey lttey commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

New feature implementation

Implemented feature

refer to feature request

Implementation description

Beside checking whether fleet name fully match in entire string, it shall be able to check also whether exist in string array. Another iteration is added.

GenAI Use

We follow OSRA's policy on GenAI tools

  • [/] I used a GenAI tool in this PR. (Claude Code Sonnet 5 for coding)
  • I did not use GenAI

@mxgrey mxgrey added this to PMC Board Jul 7, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board Jul 7, 2026
@xiyuoh

xiyuoh commented Jul 9, 2026

Copy link
Copy Markdown
Member

Hello @lttey , thanks for the contribution! Please check the DCO (you can sign your commit locally and force push), and fill in the GenAI portion properly. If you used an AI tool, please help to specify which model you used.

Signed-off-by: lttey <leong_teck_tey@cgh.com.sg>
@lttey
lttey force-pushed the feat/task_to_fleets branch from cb8b1b7 to 7aeb92d Compare July 9, 2026 06:22
@lttey

lttey commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@xiyuoh thanks. Have signed off and forced pushed for the repo as well as PR at rmf_api_msgs. Have updated AI model above as well.

@mxgrey mxgrey moved this from Inbox to In Review in PMC Board Jul 14, 2026

@mxgrey mxgrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

@cardboardcode could you run some manual tests of this branch along with open-rmf/rmf_api_msgs#64 and verify that a dispatch request that contains an array of fleet names is handled correctly? I would expect the following:

  • Empty array means no fleet is selected
  • Array with many names but no matching fleets means no fleet is selected
  • Array with many names and one match means the matching fleet is selected
  • Array with many names and multiple matching fleets means the most available fleet is selected (the hotel world demo can be used for this)
  • A string (instead of an array) means the fleet with that name is selected
  • Anything other than a string or array (e.g. a number) means the bid request fails
  • Under no circumstance is there a crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants