Skip to content

Qt5 and Qt6 compatibility#157

Merged
arjo129 merged 3 commits into
mainfrom
luca/qt5_qt6_compatibility
Oct 22, 2025
Merged

Qt5 and Qt6 compatibility#157
arjo129 merged 3 commits into
mainfrom
luca/qt5_qt6_compatibility

Conversation

@luca-della-vedova

@luca-della-vedova luca-della-vedova commented Oct 7, 2025

Copy link
Copy Markdown
Member

Bug fix

Fixed bug

Closes #155

Fix applied

Follows the approach proposed in #155 (comment), we can:

  • Remove Qt dependencies and just use the Qt version that is brought in by gz-gui.
  • Use unversioned functions for CMake.
  • Check at the qml level for the Qt version and adapt the class names with a leading underscore for qt >= 6.
  • Remove LightTuning altogether since most of its content is now available in upstream Gazebo, it has also been untested for a long time since it's not part of the default plugins but I can try to readd it if there is need for it.

I tested this in a 24.04 distrobox with either rolling or jazzy and it seems to work OK, but happy to get another pair of eyes.
Note that rolling has a few other issues, open-rmf/rmf_visualization#87 and gazebo failing to run (at least for me) because of an invalid command. I had to run Gazebo manually instead of using the launch file:

$: export GZ_SIM_RESOURCE_PATH=~/rmf_ws/install/rmf_demos_assets/share/rmf_demos_assets/models:~/rmf_ws/install/rmf_demos_maps/share/rmf_demos_maps/maps/hotel/models/
$: gz sim -r -v 3 /usr/local/google/home/lucadv/noble_ws/install/rmf_demos_maps/share/rmf_demos_maps/maps/hotel/hotel.world -z 100

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@mxgrey mxgrey added this to PMC Board Oct 7, 2025
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board Oct 7, 2025
@arjo129
arjo129 self-requested a review October 21, 2025 01:11
@mxgrey mxgrey moved this from Inbox to Todo in PMC Board Oct 21, 2025

@arjo129 arjo129 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very elegant solution to the problem of maintaining two versions of the same UI. I tested it and it seems to be working.

@arjo129
arjo129 merged commit 00e0460 into main Oct 22, 2025
5 checks passed
@arjo129
arjo129 deleted the luca/qt5_qt6_compatibility branch October 22, 2025 14:48
@github-project-automation github-project-automation Bot moved this from Todo to Done in PMC Board Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Build failure on ROS 2 Rolling Buildfarm

3 participants