Qt5 and Qt6 compatibility#157
Merged
Merged
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
arjo129
approved these changes
Oct 22, 2025
arjo129
left a comment
Member
There was a problem hiding this comment.
This is a very elegant solution to the problem of maintaining two versions of the same UI. I tested it and it seems to be working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Closes #155
Fix applied
Follows the approach proposed in #155 (comment), we can:
gz-gui.qmllevel for the Qt version and adapt the class names with a leading underscore for qt >= 6.LightTuningaltogether since most of its content is now available in upstream Gazebo, it has also been untested for a long time since it's not part of the default plugins but I can try to readd it if there is need for it.I tested this in a 24.04 distrobox with either rolling or jazzy and it seems to work OK, but happy to get another pair of eyes.
Note that rolling has a few other issues, open-rmf/rmf_visualization#87 and gazebo failing to run (at least for me) because of an invalid command. I had to run Gazebo manually instead of using the launch file:
GenAI Use
We follow OSRA's policy on GenAI tools