fix bug

Author: Agboolafeyikemi

src/app/containers/MainContainer.tsx

@@ -77,7 +77,8 @@ function MainContainer(): JSX.Element {
         break;
       }
       case 'sendSnapshots': {
-        dispatch(setTab(payload));
+        // sourceTab is the tab that sent the snapshot; setTab expects tabId, not tabsObj
+        if (typeof sourceTab === 'number') dispatch(setTab(sourceTab));
         dispatch(addNewSnapshots(payload));
         break;
       }

src/app/slices/mainSlice.ts

@@ -50,10 +50,14 @@ export const mainSlice = createSlice({
       const currSnapshot = tabs[currentTab].snapshots[tabs[currentTab].currLocation.index]; // current snapshot
       const currAxSnapshot = tabs[currentTab].axSnapshots[tabs[currentTab].currLocation.index]; // current accessibility tree snapshot
 
-      tabs[currentTab].hierarchy.stateSnapshot = { ...currSnapshot }; // resets hierarchy to current snapshot
+      // Strip lastUserEvent so jumpToSnap (from changeSlider) won't re-show the pointer
+      const cleanSnapshot = { ...currSnapshot };
+      delete (cleanSnapshot as { lastUserEvent?: unknown }).lastUserEvent;
+
+      tabs[currentTab].hierarchy.stateSnapshot = { ...cleanSnapshot }; // resets hierarchy to current snapshot
       tabs[currentTab].hierarchy.axSnapshot = { ...currAxSnapshot }; // resets hierarchy to current accessibility tree snapshot
       tabs[currentTab].hierarchy.children = []; // resets hierarchy
-      tabs[currentTab].snapshots = [currSnapshot]; // resets snapshots to current snapshot
+      tabs[currentTab].snapshots = [cleanSnapshot]; // resets snapshots to current snapshot (no lastUserEvent)
       tabs[currentTab].axSnapshots = [currAxSnapshot]; // resets snapshots to current snapshot
 
       // resets currLocation to current snapshot
@@ -200,19 +204,21 @@ export const mainSlice = createSlice({
       const { port, currentTab, tabs } = state;
       const { hierarchy, snapshots } = tabs[currentTab] || {};
 
-      // finds the name by the action.payload parsing through the hierarchy to send to background.js the current name in the jump action
-      const nameFromIndex = findName(action.payload, hierarchy);
-      // nameFromIndex is a number based on which jump button is pushed
+      const index = typeof action.payload === 'object' ? action.payload.index : action.payload;
+
+      // finds the name by the index parsing through the hierarchy to send to background.js the current name in the jump action
+      const nameFromIndex = findName(index, hierarchy);
 
+      // Always pass full snapshot so laser pointer shows when snapshot has lastUserEvent
       port.postMessage({
         action: 'jumpToSnap',
-        payload: snapshots[action.payload],
-        index: action.payload,
+        payload: snapshots[index],
+        index,
         name: nameFromIndex,
         tabId: currentTab,
       });
 
-      tabs[currentTab].sliderIndex = action.payload;
+      tabs[currentTab].sliderIndex = index;
     },
 
     setCurrentTabInApp: (state, action) => {

src/extension/background.js

@@ -512,6 +512,12 @@ chrome.runtime.onConnect.addListener(async (port) => {
         tabsObj[tabId].currBranch = 1; // reset currBranch
         tabsObj[tabId].currLocation = tabsObj[tabId].hierarchy; // reset currLocation
 
+        // Hide click-replay visualization since snapshots were cleared
+        try {
+          chrome.tabs.sendMessage(tabId, { action: 'hideClickReplay' });
+        } catch (err) {
+          // Tab may be closed or content script not loaded
+        }
         return true; // return true so that port remains open
 
       case 'setPause': // Pause = lock on tab
@@ -733,6 +739,12 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
           );
         }
 
+        // User action created new snapshot; hide click-replay visualization
+        try {
+          chrome.tabs.sendMessage(sourceTab, { action: 'hideClickReplay' });
+        } catch (err) {
+          /* tab may be closed */
+        }
         break;
       }
 
@@ -756,15 +768,29 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
 
       if (isDuplicateSnapshot(previousSnap, incomingSnap)) {
         console.warn('Duplicate snapshot detected, skipping');
+        // Still hide pointer - user interaction triggered a snapshot even if we skipped it
+        try {
+          chrome.tabs.sendMessage(sourceTab, { action: 'hideClickReplay' });
+        } catch (err) {
+          /* tab may be closed */
+        }
         break;
       }
 
       // Or if it is a snapShot after a jump, we don't record it.
+      let didAddSnapshot = false;
       if (reloaded[tabId]) {
         // don't add anything to snapshot storage if tab is reloaded for the initial snapshot
         reloaded[tabId] = false;
+        // Still hide pointer - snapshot after jump, user has moved on
+        try {
+          chrome.tabs.sendMessage(sourceTab, { action: 'hideClickReplay' });
+        } catch (err) {
+          /* tab may be closed */
+        }
       } else {
         tabsObj[tabId].snapshots.push(request.payload);
+        didAddSnapshot = true;
         // INVOKING buildHierarchy FIGURE OUT WHAT TO PASS IN
         if (!tabsObj[tabId][index]) {
           // check if accessibility recording has been toggled on
@@ -799,6 +825,15 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
       } else {
         console.warn('No active ports to send snapshots to.');
       }
+
+      // User action created new snapshot; hide click-replay visualization
+      if (didAddSnapshot) {
+        try {
+          chrome.tabs.sendMessage(sourceTab, { action: 'hideClickReplay' });
+        } catch (err) {
+          /* tab may be closed */
+        }
+      }
     }
     default:
       break;

src/extension/contentScript.ts

@@ -281,6 +281,9 @@ chrome.runtime.onMessage.addListener((request) => {
       // '*' == target window origin required for event to be dispatched, '*' = no preference
       window.postMessage(request, '*');
     }
+    if (action === 'hideClickReplay') {
+      updateClickReplayPointer(undefined);
+    }
     if (action === 'portDisconnect' && !currentPort && !isAttemptingReconnect) {
       console.log('Received disconnect message, initiating reconnection');
       // When we receive a port disconnection message, relay it to the window