Refactor version update script for clarity and efficiency

Author: baylesj

.github/workflows/update-project-version.yml

@@ -25,11 +25,10 @@ jobs:
         run: |
           VER="${{ github.event.inputs.target_version }}"
           SOVER="${{ github.event.inputs.target_soversion }}"
-          echo "bumping version to $VER"
+          echo "bumping to $VER"
 
           # 1. cmakelists.txt
           if [ -f CMakeLists.txt ]; then
-            echo "updating cmakelists.txt"
             sed -i "/project.*jsoncpp/,/)/ s/VERSION [0-9.]*/VERSION $VER/" CMakeLists.txt
             if [ -n "$SOVER" ]; then
               sed -i "s/set(PROJECT_SOVERSION [0-9]*/set(PROJECT_SOVERSION $SOVER/" CMakeLists.txt
@@ -38,8 +37,7 @@ jobs:
 
           # 2. meson.build
           if [ -f meson.build ]; then
-            echo "updating meson.build"
-            # match the version line directly
+            # targeting the version line directly
             sed -i "s/version[[:space:]]*:[[:space:]]*['\"][0-9.]*['\"]/version : '$VER'/" meson.build
             if [ -n "$SOVER" ]; then
               sed -i "s/soversion[[:space:]]*:[[:space:]]*['\"][0-9]*['\"]/soversion : '$SOVER'/" meson.build
@@ -48,20 +46,17 @@ jobs:
 
           # 3. module.bazel
           if [ -f MODULE.bazel ]; then
-            echo "updating module.bazel"
-            # surgical update only for the module() version
-            sed -i "/module(/,/)/ s/version[[:space:]]*=[[:space:]]*['\"][0-9.]*['\"]/version = \"$VER\"/" MODULE.bazel
+            # match only the first 'version' occurrence in the file (the module version)
+            sed -i "0,/version[[:space:]]*=[[:space:]]*['\"][0-9.]*['\"]/s//version = \"$VER\"/" MODULE.bazel
           fi
 
           # 4. vcpkg.json
           if [ -f vcpkg.json ]; then
-            echo "updating vcpkg.json"
-            jq --arg ver "$VER" '.version = $ver' vcpkg.json > vcpkg.json.tmp && mv vcpkg.json.tmp vcpkg.json
+            jq --arg ver "$VER" '.version = $ver' vcpkg.json > tmp.json && mv tmp.json vcpkg.json
           fi
 
           # 5. include/json/version.h
           if [ -f include/json/version.h ]; then
-            echo "updating version.h"
             MAJOR=$(echo "$VER" | cut -d. -f1)
             MINOR=$(echo "$VER" | cut -d. -f2)
             PATCH=$(echo "$VER" | cut -d. -f3)
@@ -84,33 +79,32 @@ jobs:
         run: |
           FILE="include/json/version.h"
           if [ -f "$FILE" ]; then
-            # stricter extraction to avoid catching comments or artifacts
+            # extract clean values by stripping everything except digits and dots
             V_STR=$(grep "JSONCPP_VERSION_STRING" "$FILE" | head -n 1 | cut -d '"' -f 2)
             V_MAJ=$(grep "JSONCPP_VERSION_MAJOR" "$FILE" | head -n 1 | awk '{print $3}' | tr -cd '0-9')
             V_MIN=$(grep "JSONCPP_VERSION_MINOR" "$FILE" | head -n 1 | awk '{print $3}' | tr -cd '0-9')
             V_PAT=$(grep "JSONCPP_VERSION_PATCH" "$FILE" | head -n 1 | awk '{print $3}' | tr -cd '0-9')
             V_QUA=$(grep "JSONCPP_VERSION_QUALIFIER" "$FILE" | head -n 1 | awk '{print $3}' | tr -cd '0-9')
 
-            # build table safely
-            echo "report<<EOF" >> $GITHUB_OUTPUT
+            # create a unique delimiter for the multi-line output
+            DELIM=$(dd if=/dev/urandom bs=15 count=1 2>/dev/null | base64)
+            echo "report<<$DELIM" >> $GITHUB_OUTPUT
             echo "| Macro | Value |" >> $GITHUB_OUTPUT
             echo "| :--- | :--- |" >> $GITHUB_OUTPUT
             echo "| STRING | \`$V_STR\` |" >> $GITHUB_OUTPUT
             echo "| MAJOR | \`$V_MAJ\` |" >> $GITHUB_OUTPUT
             echo "| MINOR | \`$V_MIN\` |" >> $GITHUB_OUTPUT
             echo "| PATCH | \`$V_PAT\` |" >> $GITHUB_OUTPUT
             echo "| QUALIFIER | \`${V_QUA:-empty}\` |" >> $GITHUB_OUTPUT
-            echo "EOF" >> $GITHUB_OUTPUT
+            echo "$DELIM" >> $GITHUB_OUTPUT
           fi
 
       - name: sanity check (cmake configure)
         run: |
           if [ -f CMakeLists.txt ]; then
-            mkdir build_check
-            cd build_check
+            mkdir build_check && cd build_check
             cmake .. -DJSONCPP_WITH_TESTS=OFF -DJSONCPP_WITH_POST_BUILD_UNITTEST=OFF
-            cd ..
-            rm -rf build_check
+            cd .. && rm -rf build_check
           fi
 
       - name: create pull request