Add steps for promotion for triager and approver#3450
Merged
Conversation
bogdan-st
requested review from
a team,
alolita,
austinlparker,
jpkrohling,
maryliag,
mtwo,
mx-psi,
svrnm,
tedsuo and
trask
as code owners
May 18, 2026 18:03
atoulme
approved these changes
May 26, 2026
Member
|
thanks @bogdan-st! @open-telemetry/sig-contributor-experience-approvers would be great to get your reviews, thanks. |
amy-super
approved these changes
May 27, 2026
amy-super
left a comment
amy-super
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @bogdan-st !
maryliag
approved these changes
May 27, 2026
maryliag
enabled auto-merge
May 27, 2026 19:16
trask
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for open-telemetry/sig-contributor-experience#13
This file has gone a long way since the issue has been opened so some of it has been resolved organically. This is just formalising the process for promoting people to triager or approver, which inpractice has been pretty similar to the one for maintainers.
This should add some clarity on what maintainers should expect from a nominated person in order to approve the promotion, and also for contributors to know when they should start a discussion in that direction.
I ve made the decision (which is what i have observed and also follows other OSS projects) that for triagers and approvers we should only count maintainer votes. I'd be happy to change it to include approvers if anyone thinks it should be that way.
Im still a bit confused about the approver-codeowner thing since from what i've seen in collector contrib at least they are different concepts, but that may be a different issue or just me understanding things wrong.