Skip to content

Commit 2173ab8

Browse files
authored
Fix several build warnings around deprecations (#1046)
* fix several build warnings around deprecations * rename to eliminate circular dep
1 parent a8240e4 commit 2173ab8

3 files changed

Lines changed: 20 additions & 9 deletions

File tree

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
12
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
23

34
// Top-level build file where you can add configuration options common to all sub-projects/modules.
@@ -18,6 +19,7 @@ plugins {
1819
}
1920

2021
extra["java_version"] = JavaVersion.VERSION_1_8
22+
extra["jvm_target"] = JvmTarget.JVM_1_8
2123
extra["kotlin_min_supported_version"] = KotlinVersion.KOTLIN_1_8
2224

2325
allprojects {

buildSrc/src/main/kotlin/otel.android-app-conventions.gradle.kts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
12
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
23

34
plugins {
@@ -7,6 +8,7 @@ plugins {
78
}
89

910
val javaVersion = rootProject.extra["java_version"] as JavaVersion
11+
val targetJvm = rootProject.extra["jvm_target"] as JvmTarget
1012
val minKotlinVersion = rootProject.extra["kotlin_min_supported_version"] as KotlinVersion
1113
android {
1214
namespace = "io.opentelemetry.android"
@@ -23,10 +25,12 @@ android {
2325
isCoreLibraryDesugaringEnabled = true
2426
}
2527

26-
kotlinOptions {
27-
jvmTarget = javaVersion.toString()
28-
apiVersion = minKotlinVersion.version
29-
languageVersion = minKotlinVersion.version
28+
kotlin {
29+
compilerOptions {
30+
jvmTarget.set(targetJvm)
31+
apiVersion.set(minKotlinVersion)
32+
languageVersion.set(minKotlinVersion)
33+
}
3034
}
3135

3236
packaging {

buildSrc/src/main/kotlin/otel.android-library-conventions.gradle.kts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import gradle.kotlin.dsl.accessors._d8282334f089ec6fbf714caba2b86dd9.kotlin
2+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
13
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
24

35
plugins {
@@ -9,6 +11,7 @@ plugins {
911
}
1012

1113
val javaVersion = rootProject.extra["java_version"] as JavaVersion
14+
val targetJvm = rootProject.extra["jvm_target"] as JvmTarget
1215
val minKotlinVersion = rootProject.extra["kotlin_min_supported_version"] as KotlinVersion
1316
android {
1417
compileSdk = (property("android.compileSdk") as String).toInt()
@@ -31,11 +34,13 @@ android {
3134
targetCompatibility(javaVersion)
3235
}
3336

34-
kotlinOptions {
35-
jvmTarget = javaVersion.toString()
36-
apiVersion = minKotlinVersion.version
37-
languageVersion = minKotlinVersion.version
38-
freeCompilerArgs = listOf("-Xjvm-default=all")
37+
kotlin {
38+
compilerOptions {
39+
jvmTarget.set(targetJvm)
40+
apiVersion.set(minKotlinVersion)
41+
languageVersion.set(minKotlinVersion)
42+
freeCompilerArgs.set(listOf("-Xjvm-default=all"))
43+
}
3944
}
4045
}
4146

0 commit comments

Comments
 (0)