Skip to content

Commit 2626014

Browse files
authored
Update docs to reflect that desugaring is required for minSdk < 26 (#1085)
1 parent 2cec7c2 commit 2626014

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ of the [OpenTelemetry Java SDK](https://github.com/open-telemetry/opentelemetry-
2323
> If your project's minSdk is lower than 26, then you must enable
2424
> [corelib desugaring](https://developer.android.com/studio/write/java8-support#library-desugaring).
2525
> See [#73](https://github.com/open-telemetry/opentelemetry-android/issues/73) for more information.
26-
> If your project's minSdk is lower than 24, in order to run instrumentation tests or run the app
27-
> built on debug, you must use AGP 8.3.0+ and set the `android.useFullClasspathForDexingTransform`
26+
> Further, you must use AGP 8.3.0+ and set the `android.useFullClasspathForDexingTransform`
2827
> property in `gradle.properties` to `true` to ensure desugaring runs properly. For the full
2928
> context for this workaround, please see
3029
> [this issue](https://issuetracker.google.com/issues/230454566#comment18).

instrumentation/httpurlconnection/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ A span associated with a given request is concluded in the following scenarios:
2222

2323
Spans won't be automatically ended and reported otherwise. If any of your URLConnection requests do not call the span concluding APIs mentioned above, refer the section entitled ["Scheduling Harvester Thread"](#scheduling-harvester-thread). This section provides guidance on setting up a recurring thread that identifies unreported, idle connections and ends/reports any open spans associated with them. Idle connections are those that have been read from previously but have been inactive for a particular configurable time interval (defaults to 10 seconds).
2424

25-
> The minimum supported Android SDK version is 21, though it will also instrument APIs added in the Android SDK version 24 when running on devices with API level 24 and above.
25+
> The minimum supported Android SDK version is 21, though it will also instrument APIs added in the Android SDK version 26 when running on devices with API level 26 and above.
2626
2727
> If your project's minSdk is lower than 26, then you must enable
2828
> [corelib desugaring](https://developer.android.com/studio/write/java8-support#library-desugaring).
2929
>
30-
> If your project's minSdk is lower than 24, in order to run the app built on debug, you need to add the following property in `gradle.properties` file:
31-
> - If AGP <= 8.3.0, set `android.enableDexingArtifactTransform=false`
32-
> - if AGP > 8.3.0, set `android.useFullClasspathForDexingTransform=true`
30+
> Further, in order to run the app built on debug, you need to add the following property in `gradle.properties` file:
31+
> - If AGP <= 8.3.0, set `android.enableDexingArtifactTransform=false`
32+
> - If AGP > 8.3.0, set `android.useFullClasspathForDexingTransform=true`
3333
>
3434
> For the full context for these workaround, please see
3535
> [this issue](https://issuetracker.google.com/issues/334281968) for AGP <= 8.3.0

0 commit comments

Comments
 (0)