Skip to content

Commit 8cb0fbc

Browse files
authored
Remove deprecated sdk ready listeners. (#1731)
* remove deprecated sdk ready listeners. * add changelog
1 parent e5a4275 commit 8cb0fbc

4 files changed

Lines changed: 5 additions & 37 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
## Unreleased
44

5+
### ⚠️⚠️ Breaking changes
6+
7+
- Remove deprecated sdk ready listeners. Users should use the otel ready listeners instead.
8+
([#1731](https://github.com/open-telemetry/opentelemetry-android/pull/1731))
9+
510
## Version 1.3.0 (2026-04-22)
611

712
### ⚠️⚠️ Breaking changes

core/api/core.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ public final class io/opentelemetry/android/OpenTelemetryRumBuilder {
1111
public final fun addMeterProviderCustomizer (Ljava/util/function/BiFunction;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
1212
public final fun addMetricExporterCustomizer (Ljava/util/function/Function;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
1313
public final fun addOtelReadyListener (Lkotlin/jvm/functions/Function1;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
14-
public final fun addOtelSdkReadyListener (Ljava/util/function/Consumer;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
1514
public final fun addPropagatorCustomizer (Ljava/util/function/Function;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
1615
public final fun addSpanExporterCustomizer (Ljava/util/function/Function;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;
1716
public final fun addTracerProviderCustomizer (Ljava/util/function/BiFunction;)Lio/opentelemetry/android/OpenTelemetryRumBuilder;

core/src/main/java/io/opentelemetry/android/OpenTelemetryRumBuilder.kt

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@ class OpenTelemetryRumBuilder internal constructor(
107107

108108
val instrumentationLoader: AndroidInstrumentationLoader = AndroidInstrumentationLoaderImpl()
109109

110-
@Deprecated("SDK listeners are deprecated, use otelReadyListeners instead")
111-
private val otelSdkReadyListeners: MutableList<Consumer<OpenTelemetrySdk>> = mutableListOf()
112-
113110
private val otelReadyListeners: MutableList<(OpenTelemetry) -> Unit> = mutableListOf()
114111

115112
private var spanExporterCustomizer: (SpanExporter) -> SpanExporter = { it }
@@ -279,22 +276,6 @@ class OpenTelemetryRumBuilder internal constructor(
279276
return this
280277
}
281278

282-
/**
283-
* Adds a callback to be invoked after the OpenTelemetry SDK has been initialized. This can be
284-
* used to defer some early lifecycle functionality until the working SDK is ready.
285-
*
286-
* @param callback - A callback that receives the OpenTelemetry SDK instance.
287-
* @return this
288-
*/
289-
@Deprecated(
290-
message = "OtelSdkReadyListeners will be removed in a future release",
291-
replaceWith = ReplaceWith("addOtelReadyListener(callback)"),
292-
)
293-
fun addOtelSdkReadyListener(callback: Consumer<OpenTelemetrySdk>): OpenTelemetryRumBuilder {
294-
otelSdkReadyListeners.add(callback)
295-
return this
296-
}
297-
298279
/**
299280
* Adds a callback to be invoked after the OpenTelemetry instance has been initialized. This can be
300281
* used to defer some early lifecycle functionality until the OpenTelemetry instance is ready.
@@ -358,11 +339,6 @@ class OpenTelemetryRumBuilder internal constructor(
358339
).setPropagators(buildFinalPropagators())
359340
.build()
360341

361-
otelSdkReadyListeners.forEach(
362-
Consumer {
363-
it.accept(sdk)
364-
},
365-
)
366342
otelReadyListeners.forEach { it(sdk) }
367343

368344
val delegate =

core/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -537,18 +537,6 @@ class OpenTelemetryRumBuilderTest {
537537
}
538538
}
539539

540-
@Test
541-
fun sdkReadyListeners() {
542-
val config = buildConfig()
543-
val seen = AtomicReference<OpenTelemetrySdk>()
544-
createAndSetServiceManager()
545-
RumBuilder
546-
.builder(application, config)
547-
.addOtelSdkReadyListener { newValue: OpenTelemetrySdk -> seen.set(newValue) }
548-
.build()
549-
assertThat(seen.get()).isNotNull()
550-
}
551-
552540
@Test
553541
fun otelReadyListeners() {
554542
val config = buildConfig()

0 commit comments

Comments
 (0)