Skip to content

Commit a45379b

Browse files
committed
handle renamed method and match in instrumentation
1 parent dce80ac commit a45379b

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

instrumentation/okhttp3/library/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentation.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class OkHttpInstrumentation implements AndroidInstrumentation {
3333
private List<String> capturedResponseHeaders = new ArrayList<>();
3434
private Set<String> knownMethods = HttpConstants.KNOWN_METHODS;
3535
private Map<String, String> peerServiceMapping = new HashMap<>();
36-
private boolean emitExperimentalHttpClientMetrics;
36+
private boolean emitExperimentalHttpClientTelemetry;
3737

3838
/** Adds an {@link AttributesExtractor} that will extract additional attributes. */
3939
public void addAttributesExtractor(AttributesExtractor<Interceptor.Chain, Response> extractor) {
@@ -129,12 +129,13 @@ public PeerServiceResolver newPeerServiceResolver() {
129129
* href="https://github.com/open-telemetry/semantic-conventions/blob/main/specification/metrics/semantic_conventions/http-metrics.md#metric-httpclientresponsesize">
130130
* the response size</a>.
131131
*/
132-
public void setEmitExperimentalHttpClientMetrics(boolean emitExperimentalHttpClientMetrics) {
133-
this.emitExperimentalHttpClientMetrics = emitExperimentalHttpClientMetrics;
132+
public void setEmitExperimentalHttpClientTelemetry(
133+
boolean emitExperimentalHttpClientTelemetry) {
134+
this.emitExperimentalHttpClientTelemetry = emitExperimentalHttpClientTelemetry;
134135
}
135136

136-
public boolean emitExperimentalHttpClientMetrics() {
137-
return emitExperimentalHttpClientMetrics;
137+
public boolean emitExperimentalHttpClientTelemetry() {
138+
return emitExperimentalHttpClientTelemetry;
138139
}
139140

140141
@Override

instrumentation/okhttp3/library/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/internal/OkHttp3Singletons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public static void configure(
5353
OkHttpAttributesGetter.INSTANCE,
5454
instrumentation.newPeerServiceResolver()))
5555
.setEmitExperimentalHttpClientTelemetry(
56-
instrumentation.emitExperimentalHttpClientMetrics());
56+
instrumentation.emitExperimentalHttpClientTelemetry());
5757

5858
for (AttributesExtractor<Interceptor.Chain, Response> extractor :
5959
instrumentation.getAdditionalExtractors()) {

0 commit comments

Comments
 (0)