fix: address some build warnings in the project

Author: fractalwrench

core/src/test/java/io/opentelemetry/android/SessionIdRatioBasedSamplerTest.kt

@@ -38,7 +38,7 @@ internal class SessionIdRatioBasedSamplerTest {
     fun samplerDropsHigh() {
         every { sessionProvider.getSessionId() } returns HIGH_ID
 
-        val sampler = SessionIdRatioBasedSampler(0.5, sessionProvider!!)
+        val sampler = SessionIdRatioBasedSampler(0.5, sessionProvider)
 
         // Sampler drops if TraceIdRatioBasedSampler would drop this sessionId
         assertThat(shouldSample(sampler)).isEqualTo(SamplingDecision.DROP)
@@ -49,7 +49,7 @@ internal class SessionIdRatioBasedSamplerTest {
         // Sampler accepts if TraceIdRatioBasedSampler would accept this sessionId
         every { sessionProvider.getSessionId() } returns LOW_ID
 
-        val sampler = SessionIdRatioBasedSampler(0.5, sessionProvider!!)
+        val sampler = SessionIdRatioBasedSampler(0.5, sessionProvider)
         assertThat(shouldSample(sampler)).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE)
     }
 
@@ -58,13 +58,13 @@ internal class SessionIdRatioBasedSamplerTest {
         every { sessionProvider.getSessionId() } returns HIGH_ID
 
         val samplerHigh =
-            SessionIdRatioBasedSampler(0.0, sessionProvider!!)
+            SessionIdRatioBasedSampler(0.0, sessionProvider)
         assertThat(shouldSample(samplerHigh)).isEqualTo(SamplingDecision.DROP)
 
         every { sessionProvider.getSessionId() } returns LOW_ID
 
         val samplerLow =
-            SessionIdRatioBasedSampler(0.0, sessionProvider!!)
+            SessionIdRatioBasedSampler(0.0, sessionProvider)
         assertThat(shouldSample(samplerLow)).isEqualTo(SamplingDecision.DROP)
     }
 
@@ -73,13 +73,13 @@ internal class SessionIdRatioBasedSamplerTest {
         every { sessionProvider.getSessionId() } returns HIGH_ID
 
         val samplerHigh =
-            SessionIdRatioBasedSampler(1.0, sessionProvider!!)
+            SessionIdRatioBasedSampler(1.0, sessionProvider)
         assertThat(shouldSample(samplerHigh)).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE)
 
         every { sessionProvider.getSessionId() } returns LOW_ID
 
         val samplerLow =
-            SessionIdRatioBasedSampler(1.0, sessionProvider!!)
+            SessionIdRatioBasedSampler(1.0, sessionProvider)
         assertThat(shouldSample(samplerLow)).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE)
     }
 

instrumentation/activity/src/main/java/io/opentelemetry/android/instrumentation/activity/startup/AppStartupTimer.java

@@ -134,7 +134,7 @@ public void detectBackgroundStart(Handler handler) {
     private static class StartFromBackgroundRunnable implements Runnable {
         private final AppStartupTimer startupTimer;
 
-        public StartFromBackgroundRunnable(AppStartupTimer startupTimer) {
+        private StartFromBackgroundRunnable(AppStartupTimer startupTimer) {
             this.startupTimer = startupTimer;
         }
 

instrumentation/httpurlconnection/library/src/main/java/io/opentelemetry/instrumentation/library/httpurlconnection/HttpUrlReplacements.java

@@ -369,7 +369,7 @@ private static class InstrumentedInputStream extends InputStream {
 
         private final InputStream inputStream;
 
-        public InstrumentedInputStream(URLConnection connection, InputStream inputStream) {
+        private InstrumentedInputStream(URLConnection connection, InputStream inputStream) {
             this.connection = connection;
             this.inputStream = inputStream;
         }

instrumentation/startup/src/test/java/io/opentelemetry/android/instrumentation/startup/SdkInitializationEventsTest.kt

@@ -10,7 +10,6 @@ import io.mockk.every
 import io.mockk.mockk
 import io.mockk.verify
 import io.opentelemetry.android.common.RumConstants
-import io.opentelemetry.android.test.common.hasEventName
 import io.opentelemetry.api.common.AttributeKey.stringKey
 import io.opentelemetry.api.common.Attributes
 import io.opentelemetry.api.common.Value

instrumentation/volley/library/consumer-rules.pro

@@ -91,6 +91,7 @@ internal class PostApi28NetworkDetector
             return builder.build()
         }
 
+        @Suppress("DEPRECATION") // suppress deprecated network type
         private fun getDataNetworkTypeName(dataNetworkType: Int): String =
             when (dataNetworkType) {
                 NETWORK_TYPE_1xRTT -> "1xRTT"

services/src/main/java/io/opentelemetry/android/internal/services/network/detector/PostApi28NetworkDetector.kt

@@ -23,6 +23,7 @@
 import org.robolectric.annotation.Config;
 import org.robolectric.shadows.ShadowNetworkInfo;
 
+@SuppressWarnings("deprecation") // suppress warnings around deprecated network state APIs
 @RunWith(AndroidJUnit4.class)
 @Config(sdk = Build.VERSION_CODES.P)
 public class SimpleNetworkDetectorTest {