Add agent dsl to disable instrumentations (#1714)

* add dsl that allows suppressing some automatically loaded instrumentations by name.

* detekt

* update api

* add kdoc

Author: breedx-splk

android-agent/api/android-agent.api

@@ -106,6 +106,7 @@ public final class io/opentelemetry/android/agent/dsl/instrumentation/Instrument
 	public final fun networkMonitoring (Lkotlin/jvm/functions/Function1;)V
 	public final fun screenOrientation (Lkotlin/jvm/functions/Function1;)V
 	public final fun slowRenderingReporter (Lkotlin/jvm/functions/Function1;)V
+	public final fun suppressing ([Ljava/lang/String;)V
 }
 
 public final class io/opentelemetry/android/agent/dsl/instrumentation/NetworkMonitoringConfiguration : io/opentelemetry/android/agent/dsl/instrumentation/CanBeEnabledAndDisabled {

android-agent/src/main/kotlin/io/opentelemetry/android/agent/dsl/instrumentation/InstrumentationConfiguration.kt

@@ -14,7 +14,7 @@ import io.opentelemetry.android.instrumentation.AndroidInstrumentationLoader
  */
 @OpenTelemetryDslMarker
 class InstrumentationConfiguration internal constructor(
-    config: OtelRumConfig,
+    private val config: OtelRumConfig,
     private val instrumentationLoader: AndroidInstrumentationLoader,
 ) {
     private val activity: ActivityLifecycleConfiguration by lazy {
@@ -84,4 +84,16 @@ class InstrumentationConfiguration internal constructor(
     fun screenOrientation(configure: ScreenOrientationConfiguration.() -> Unit) {
         screenOrientation.configure()
     }
+
+    /**
+     * Suppresses the named instrumentations so they will not be installed at startup.
+     *
+     * The values passed here must match the instrumentation names as exposed by
+     * AndroidInstrumentation.
+     */
+    fun suppressing(vararg instrumentationsToExclude: String) {
+        instrumentationsToExclude.forEach {
+            config.suppressInstrumentation(it)
+        }
+    }
 }

android-agent/src/test/kotlin/io/opentelemetry/android/agent/dsl/InstrumentationConfigurationTest.kt

@@ -0,0 +1,40 @@
+package io.opentelemetry.android.agent.dsl
+
+import io.mockk.every
+import io.mockk.mockk
+import io.mockk.verify
+import io.opentelemetry.android.agent.FakeClock
+import io.opentelemetry.android.agent.FakeInstrumentationLoader
+import io.opentelemetry.android.config.OtelRumConfig
+import io.opentelemetry.android.features.diskbuffering.DiskBufferingConfig
+import org.junit.Before
+import org.junit.Test
+
+class InstrumentationConfigurationTest {
+    private lateinit var otelConfig: OpenTelemetryConfiguration
+    private lateinit var rumConfig: OtelRumConfig
+
+    @Before
+    fun setUp() {
+        rumConfig = mockk()
+        every { rumConfig.setDiskBufferingConfig(any<DiskBufferingConfig>()) } returns rumConfig
+        every { rumConfig.suppressInstrumentation(any<String>()) } returns rumConfig
+        otelConfig = OpenTelemetryConfiguration(
+            rumConfig = rumConfig,
+            instrumentationLoader = FakeInstrumentationLoader(),
+            clock = FakeClock()
+        )
+    }
+
+    @Test
+    fun canSuppressInstrumentation() {
+        otelConfig.instrumentations {
+            suppressing("one", "two", "three")
+        }
+        verify {
+            rumConfig.suppressInstrumentation("one")
+            rumConfig.suppressInstrumentation("two")
+            rumConfig.suppressInstrumentation("three")
+        }
+    }
+}

demo-app/src/main/java/io/opentelemetry/android/demo/OtelDemoApplication.kt

@@ -41,7 +41,16 @@ class OtelDemoApplication : Application() {
                     globalAttributes {
                         Attributes.of(stringKey("toolkit"), "jetpack compose")
                     }
-                }
+                    instrumentations {
+                        suppressing (
+                            "unwanted.instrumentation.name",
+                            "something.unwanted"
+                        )
+                        screenOrientation {
+                            enabled(false)
+                        }
+                    }
+                },
             )
             ViewClickInstrumentation().install(this, rum!!)
             Log.d(TAG, "RUM session started: " + rum?.sessionProvider?.getSessionId())