NetworkChange instrumentation uninstall impl#1639
Merged
breedx-splk merged 1 commit intoApr 3, 2026
Merged
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
==========================================
+ Coverage 61.67% 61.78% +0.11%
==========================================
Files 159 159
Lines 3418 3431 +13
Branches 348 350 +2
==========================================
+ Hits 2108 2120 +12
Misses 1215 1215
- Partials 95 96 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PenguinDan
changed the title
breedx-splk
approved these changes
Mar 12, 2026
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Made two small suggestions, but this is great. Thanks for helping out!
fractalwrench
added
the
needs author feedback
Contributor
Author
|
@fractalwrench This should be ready to be merged in unless we have any other suggestions? 👀 |
Member
|
There are unresolved comments from @breedx-splk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the uninstall function for the NetworkChange Instrumentation and fixes one of the items in #1128