Only run the assembleRelease target to verify the demo app compiles#1083
Merged
Conversation
breedx-splk
approved these changes
Jul 23, 2025
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Given how slow the build is, I'm ok with this, but agree that it's not as thorough. I will wait for @LikeTheSalad to chime in before merging. Thanks!!
LikeTheSalad
approved these changes
Jul 24, 2025
Contributor
I think this is fine for the demo app since we mostly just want to avoid breaking its compilation with the agent changes, and usually the most breakable variant is the release one with the R8 stuff that goes on in there 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the scope of verification of the demo-app by only assembling the release version and bypass debug, lint, and other checks. Doing debug will be even faster but having it go through release and the APK optimizations (including desugaring) is a more comprehensive verification.