Improve perf of current network tests#1084
Merged
Merged
Conversation
fractalwrench
approved these changes
Jul 24, 2025
| .subType("LTE") | ||
| .build() | ||
| private val noNetwork = CurrentNetwork.builder(NetworkState.NO_NETWORK_AVAILABLE).build() | ||
| private val mockConnectivityManager = mockk<ConnectivityManager>() |
Member
There was a problem hiding this comment.
I'm reasonably sure this mock is taking a long time to construct, but I'll investigate that in a separate changeset later this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was running a lot of redundant API versions, which all has a fixed cost to spin up for the first time it was also unnecessarily reinitializing a lot of mocks that aren't inspected.
This PR curates a set of API versions that are relevant (i.e. code contains checks that differentiate behavior), as well as clean up some of the redundancies that are impactful.