Skip to content

Address some build warnings in the project#1118

Merged
breedx-splk merged 1 commit into
open-telemetry:mainfrom
embrace-io:fractalwrench/address-build-warnings
Aug 7, 2025
Merged

Address some build warnings in the project#1118
breedx-splk merged 1 commit into
open-telemetry:mainfrom
embrace-io:fractalwrench/address-build-warnings

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

I noticed some build warnings when running ./gradlew assembleRelease check and attempted to fix the easy ones. The build warnings were:

  • Unnecessary null checks
  • Unnecessary public modifier on a private class
  • Use of deprecated android APIs
  • Missing proguard files

@fractalwrench fractalwrench requested a review from a team as a code owner July 31, 2025 09:36
Copy link
Copy Markdown
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breedx-splk
Copy link
Copy Markdown
Contributor

doh sorry @fractalwrench looks like this needs a rebase now.

@fractalwrench fractalwrench force-pushed the fractalwrench/address-build-warnings branch from b4640e5 to 98c62f5 Compare August 7, 2025 05:39
@fractalwrench
Copy link
Copy Markdown
Member Author

No problem @breedx-splk - I've rebased this

@breedx-splk breedx-splk merged commit 4cf9ade into open-telemetry:main Aug 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants