Convert additional instrumentation classes to kotlin#1139
Merged
breedx-splk merged 1 commit intoAug 12, 2025
Conversation
fractalwrench
force-pushed
the
fractalwrench/convert-kt-2
branch
from
d643e6e to
46a84b0
Compare
marandaneto
approved these changes
Aug 12, 2025
breedx-splk
added a commit
to breedx-splk/opentelemetry-android
that referenced
this pull request
Aug 13, 2025
Merged
breedx-splk
added a commit
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Continues converting some more of the instrumentation code to Kotlin. I've avoided API breaking changes by relying on the API validation added in #1124 which should detect any changes to the public API. The only change is functions/classes are final by default in Kotlin.
The ultimate goal of these changes is to migrate from kapt to ksp. Doing this requires migrating away from
@AutoServiceto a Kotlin solution that uses the same annotation, and as part of this, it'll be necessary to migrate these classes to Kotlin.This PR is related to #1133