Convert OpenTelemetryRum interface to kotlin#1279
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 63.94% 64.00% +0.05%
==========================================
Files 142 142
Lines 3045 3050 +5
Branches 302 302
==========================================
+ Hits 1947 1952 +5
+ Misses 1020 1019 -1
- Partials 78 79 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c20614 to
c9a6511
Compare
breedx-splk
reviewed
Oct 2, 2025
breedx-splk
reviewed
Oct 2, 2025
c9a6511 to
b488773
Compare
LikeTheSalad
approved these changes
Oct 3, 2025
LikeTheSalad
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Added a small comment on one of Jason's, but I'm fine with whatever option you guys decide to go with.
d239ff9 to
8ca548f
Compare
8ca548f to
328fc46
Compare
breedx-splk
approved these changes
Oct 10, 2025
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Progress! Thanks so much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Converts the
OpenTelemetryRuminterface to Kotlin so that we can get to a point where all APIs in thecoremodule are Kotlin.Testing
Largely relied on existing testing and API checks, although I added a small unit test for the noop scenario.