Skip to content

Convert OpenTelemetryRum interface to kotlin#1279

Merged
breedx-splk merged 1 commit into
open-telemetry:mainfrom
embrace-io:convert-otel-rum
Oct 10, 2025
Merged

Convert OpenTelemetryRum interface to kotlin#1279
breedx-splk merged 1 commit into
open-telemetry:mainfrom
embrace-io:convert-otel-rum

Conversation

@fractalwrench

Copy link
Copy Markdown
Member

Goal

Converts the OpenTelemetryRum interface to Kotlin so that we can get to a point where all APIs in the core module are Kotlin.

Testing

Largely relied on existing testing and API checks, although I added a small unit test for the noop scenario.

@fractalwrench fractalwrench requested a review from a team as a code owner October 2, 2025 15:30
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (1f6c876) to head (328fc46).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../java/io/opentelemetry/android/OpenTelemetryRum.kt 36.36% 7 Missing ⚠️
...emetry/android/test/common/OpenTelemetryRumRule.kt 0.00% 2 Missing ⚠️
...a/io/opentelemetry/android/NoopOpenTelemetryRum.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   63.94%   64.00%   +0.05%     
==========================================
  Files         142      142              
  Lines        3045     3050       +5     
  Branches      302      302              
==========================================
+ Hits         1947     1952       +5     
+ Misses       1020     1019       -1     
- Partials       78       79       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread core/src/main/java/io/opentelemetry/android/OpenTelemetryRum.kt
Comment thread core/src/main/java/io/opentelemetry/android/OpenTelemetryRum.kt

@LikeTheSalad LikeTheSalad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a small comment on one of Jason's, but I'm fine with whatever option you guys decide to go with.

Comment thread core/src/main/java/io/opentelemetry/android/OpenTelemetryRum.kt
@fractalwrench fractalwrench force-pushed the convert-otel-rum branch 3 times, most recently from d239ff9 to 8ca548f Compare October 9, 2025 16:19

@breedx-splk breedx-splk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress! Thanks so much.

@breedx-splk breedx-splk merged commit 1c8082d into open-telemetry:main Oct 10, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants