Skip to content

Remove all usages of ExtendedLog*#1280

Merged
breedx-splk merged 4 commits into
open-telemetry:mainfrom
breedx-splk:remove_extended_log_usages
Oct 6, 2025
Merged

Remove all usages of ExtendedLog*#1280
breedx-splk merged 4 commits into
open-telemetry:mainfrom
breedx-splk:remove_extended_log_usages

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

This includes:

  • ExtendedLogger
  • ExtendedLogRecordBuilder
  • ExtendedLogRecord
  • ExtendedLogRecordData

We originally used these while the event name field on logs was incubating, but it's stable now and these extended usages are superfluous.

@breedx-splk breedx-splk requested a review from a team as a code owner October 2, 2025 17:46
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.94%. Comparing base (98071d6) to head (a4c44c3).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...on/library/log/internal/LogRecordBuilderCreator.kt 0.00% 3 Missing ⚠️
..._0/websocket/internal/WebsocketEventGenerator.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   64.30%   63.94%   -0.37%     
==========================================
  Files         142      142              
  Lines        3012     3045      +33     
  Branches      296      302       +6     
==========================================
+ Hits         1937     1947      +10     
- Misses        998     1020      +22     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fractalwrench fractalwrench left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread demo-app/src/main/java/io/opentelemetry/android/demo/OtelDemoApplication.kt Outdated

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

…pplication.kt

Co-authored-by: Jamie Lynch <fractalwrench@gmail.com>
@breedx-splk breedx-splk merged commit 8627d9f into open-telemetry:main Oct 6, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants