Skip to content

feat: support fullUrl in EndpointConfiguration to bypass default signal path appending#1715

Closed
Cloud-Architect-Emma wants to merge 2 commits into
open-telemetry:mainfrom
Cloud-Architect-Emma:fix-custom-signal-url
Closed

feat: support fullUrl in EndpointConfiguration to bypass default signal path appending#1715
Cloud-Architect-Emma wants to merge 2 commits into
open-telemetry:mainfrom
Cloud-Architect-Emma:fix-custom-signal-url

Conversation

@Cloud-Architect-Emma
Copy link
Copy Markdown

Fixes #1712

Summary

When using HttpExportConfiguration, the signal-specific paths (/v1/logs, /v1/traces, /v1/metrics) are always appended to the base URL. This makes it impossible to use a custom endpoint path like /v2/logs.

This PR adds a fullUrl property to EndpointConfiguration that, when set, bypasses the automatic path appending and uses the provided URL as-is.

Usage

httpExport {
    baseUrl = "https://example.com"
    logs {
        fullUrl = "https://example.com/v2/logs"  // used as-is, no path appended
    }
    // traces still uses: https://example.com/v1/traces
    // metrics still uses: https://example.com/v1/metrics
}

Changes

  • Added fullUrl: String? property to EndpointConfiguration
  • Updated HttpExportConfiguration to use fullUrl when set, falling back to existing url + path behaviour
  • Updated HttpEndpointConnectivity.forTraces/forLogs/forMetrics to accept a fullUrl flag
  • Added tests covering the new behaviour

@Cloud-Architect-Emma Cloud-Architect-Emma requested a review from a team as a code owner May 1, 2026 16:08
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 1, 2026

CLA Not Signed

@breedx-splk
Copy link
Copy Markdown
Contributor

Thanks @Cloud-Architect-Emma.

Before we can review and accept this PR, you will need to do 3 things:

  • please make sure you read CONTRIBUTING.md
  • enable signed commits (you can rewrite the PR history)
  • sign the contributor license agreement (CLA)

Thanks so much!

@breedx-splk breedx-splk added the needs author feedback Waiting for additional feedback from the author label May 1, 2026
@Cloud-Architect-Emma Cloud-Architect-Emma force-pushed the fix-custom-signal-url branch 2 times, most recently from 6cc4804 to dcb7c4a Compare May 1, 2026 21:53
…al path

Signed-off-by: Emmanuela Opurum <youremail@example.com>
@Cloud-Architect-Emma
Copy link
Copy Markdown
Author

Cloud-Architect-Emma commented May 4, 2026

@breedx-splk I've signed the CLA, received the confirmation email from EasyCLA for days. Could you please re-trigger the CLA check? It may not have refreshed automatically.

Thank you.

@breedx-splk breedx-splk closed this May 4, 2026
@breedx-splk breedx-splk reopened this May 4, 2026
@breedx-splk
Copy link
Copy Markdown
Contributor

Hmmmm. @Cloud-Architect-Emma I don't seem to have an option to retrigger. I tried closing and reopening but it didn't work to clear it. Would you mind clicking through the the process/steps again to see if that helps? Thanks again.

@Cloud-Architect-Emma
Copy link
Copy Markdown
Author

@breedx-splk, Thanks for refreshing the PR. I received this CLA confirmation mail: Hello EMMANUELA OPURUM,

This is a notification email from EasyCLA regarding the project OpenTelemetry.

The CLA has now been signed. You can download the signed CLA

Can you guide me on what I need to do to fix it?

@breedx-splk
Copy link
Copy Markdown
Contributor

/easycla

@breedx-splk
Copy link
Copy Markdown
Contributor

@Cloud-Architect-Emma I think that when you redo your commits with signing enabled it will probably retrigger the EasyCLA check...but you can also try closing and reopening this PR. It didn't work when I tried it, but maybe since you're the author it will work? 🤞🏻

Signed-off-by: Emmanuela Opurum <youremail@example.com>
@breedx-splk
Copy link
Copy Markdown
Contributor

@Cloud-Architect-Emma I'm so sorry, I know this is frustrating and confusing....and I've now learned that what I told you about signed commits is inaccurate! We do not require signed commits, sorry for suggesting that we do.

As far as the EasyCLA goes -- let me see if I can get us some help around this. In the meantime, another thing you could try is to recreate the PR from another branch? Sorry, I know this is a hassle.

@breedx-splk
Copy link
Copy Markdown
Contributor

/easycla

@breedx-splk
Copy link
Copy Markdown
Contributor

Oh I think I see what the issue is now. It looks like you've got two accounts and/or the commits were made from a different identity than the PR was submitted from.

For example, looking at the first commit:
image

it says "Emmanuela Opurum" and that little gray github icon is an indication that this is a different identity. The identity that signed the EasyCLA should be the same identity as the one that made the commits.

@Cloud-Architect-Emma
Copy link
Copy Markdown
Author

Closing in favour of #1723, which resolves the EasyCLA identity
issue and fixes the detekt violations. All changes are identical, the new
PR is a clean re-submission from the correct account identity.

Thank you @breedx-splk for your patience throughout this process.

@Cloud-Architect-Emma
Copy link
Copy Markdown
Author

Hi @breedx-splk, quick update, the line endings and detekt issues are
now fixed! EasyCLA is passing.

The only remaining blocker is a conflict in android-agent/api/android-agent.api.
This file is auto-generated by Gradle and I'm unable to run it locally
without the Android SDK set up.

Could you resolve it by running:

./gradlew :android-agent:apiDump

and pushing to my branch? That should be the very last thing needed
before this PR is ready for review.

PR: feat: support fullUrl in EndpointConfiguration to bypass default signal path appending](https://github.com/open-telemetry/opentelemetry-android/pull/1723#top)#1723

I'm really sorry for all the trouble and deeply appreciate your patience.
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs author feedback Waiting for additional feedback from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How can I specify a url for my logs in HttpExportConfiguration with different endpoint than v1/logs?

2 participants