feat: support fullUrl in EndpointConfiguration to bypass default signal path appending#1715
Conversation
|
|
Thanks @Cloud-Architect-Emma. Before we can review and accept this PR, you will need to do 3 things:
Thanks so much! |
6cc4804 to
dcb7c4a
Compare
…al path Signed-off-by: Emmanuela Opurum <youremail@example.com>
dcb7c4a to
eca7f06
Compare
|
@breedx-splk I've signed the CLA, received the confirmation email from EasyCLA for days. Could you please re-trigger the CLA check? It may not have refreshed automatically. Thank you. |
|
Hmmmm. @Cloud-Architect-Emma I don't seem to have an option to retrigger. I tried closing and reopening but it didn't work to clear it. Would you mind clicking through the the process/steps again to see if that helps? Thanks again. |
|
@breedx-splk, Thanks for refreshing the PR. I received this CLA confirmation mail: Hello EMMANUELA OPURUM, This is a notification email from EasyCLA regarding the project OpenTelemetry. The CLA has now been signed. You can download the signed CLA Can you guide me on what I need to do to fix it? |
|
/easycla |
|
@Cloud-Architect-Emma I think that when you redo your commits with signing enabled it will probably retrigger the EasyCLA check...but you can also try closing and reopening this PR. It didn't work when I tried it, but maybe since you're the author it will work? 🤞🏻 |
Signed-off-by: Emmanuela Opurum <youremail@example.com>
|
@Cloud-Architect-Emma I'm so sorry, I know this is frustrating and confusing....and I've now learned that what I told you about signed commits is inaccurate! We do not require signed commits, sorry for suggesting that we do. As far as the EasyCLA goes -- let me see if I can get us some help around this. In the meantime, another thing you could try is to recreate the PR from another branch? Sorry, I know this is a hassle. |
|
/easycla |
|
Closing in favour of #1723, which resolves the EasyCLA identity Thank you @breedx-splk for your patience throughout this process. |
|
Hi @breedx-splk, quick update, the line endings and detekt issues are The only remaining blocker is a conflict in android-agent/api/android-agent.api. Could you resolve it by running: ./gradlew :android-agent:apiDump and pushing to my branch? That should be the very last thing needed PR: feat: support fullUrl in EndpointConfiguration to bypass default signal path appending](https://github.com/open-telemetry/opentelemetry-android/pull/1723#top)#1723 I'm really sorry for all the trouble and deeply appreciate your patience. |

Fixes #1712
Summary
When using
HttpExportConfiguration, the signal-specific paths (/v1/logs,/v1/traces,/v1/metrics) are always appended to the base URL. This makes it impossible to use a custom endpoint path like/v2/logs.This PR adds a
fullUrlproperty toEndpointConfigurationthat, when set, bypasses the automatic path appending and uses the provided URL as-is.Usage
httpExport { baseUrl = "https://example.com" logs { fullUrl = "https://example.com/v2/logs" // used as-is, no path appended } // traces still uses: https://example.com/v1/traces // metrics still uses: https://example.com/v1/metrics }Changes
fullUrl: String?property toEndpointConfigurationHttpExportConfigurationto usefullUrlwhen set, falling back to existingurl+ path behaviourHttpEndpointConnectivity.forTraces/forLogs/forMetricsto accept afullUrlflag