Skip to content

Treat empty fullUrl as null/missing#1749

Merged
LikeTheSalad merged 1 commit into
open-telemetry:mainfrom
breedx-splk:improve_full_url_handling
May 19, 2026
Merged

Treat empty fullUrl as null/missing#1749
LikeTheSalad merged 1 commit into
open-telemetry:mainfrom
breedx-splk:improve_full_url_handling

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

Minor improvement after #1723, which slightly changed how an empty configuration string would be handled.

Prior to #1723 we would check for empty before falling back. This same approach needs to also happen with the fullUrl, so that if a user configures an empty string as a fullUrl, we still just use the locally scoped url.

…m. Just in case of misconfiguration or other user error.
@breedx-splk breedx-splk requested a review from a team as a code owner May 18, 2026 23:43
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.61%. Comparing base (e6ec3c1) to head (5c2a63e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1749   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files         158      158           
  Lines        3423     3423           
  Branches      345      345           
=======================================
  Hits         2109     2109           
  Misses       1217     1217           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fractalwrench fractalwrench left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LikeTheSalad LikeTheSalad merged commit 0bf26b3 into open-telemetry:main May 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants