Treat empty fullUrl as null/missing#1749
Merged
LikeTheSalad merged 1 commit intoMay 19, 2026
Merged
Conversation
…m. Just in case of misconfiguration or other user error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
=======================================
Coverage 61.61% 61.61%
=======================================
Files 158 158
Lines 3423 3423
Branches 345 345
=======================================
Hits 2109 2109
Misses 1217 1217
Partials 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LikeTheSalad
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvement after #1723, which slightly changed how an empty configuration string would be handled.
Prior to #1723 we would check for empty before falling back. This same approach needs to also happen with the fullUrl, so that if a user configures an empty string as a fullUrl, we still just use the locally scoped url.