Added scroll and fling to view-click. References #1576#1780
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
+ Coverage 62.99% 63.37% +0.38%
==========================================
Files 157 157
Lines 3448 3492 +44
Branches 352 356 +4
==========================================
+ Hits 2172 2213 +41
Misses 1179 1179
- Partials 97 100 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not sure exactly why the x and y distances are negated. I assumed it would just be the vertical axis because of how the coordinate system works compared to a regular Cartesian plane with the y axis flipped. But yeah, I'll leave it like that |
breedx-splk
left a comment
There was a problem hiding this comment.
This is great! Thanks @DavidGrath .
|
@DavidGrath did you want to repackage this instrumentation before merge, or would you prefer to do that in a follow-up effort/PR? |
|
@breedx-splk , in a follow up, so that I can add the scaling gesture as well |
That works for me. Please open a tracking issue in the meantime. 👍🏻 |
Adds scroll and fling. Adds suggestions from #1741 (comment) by @marandaneto
At this point, I think the instrumentation has gone beyond the name of "click". I'd like to ask how to address the nomenclature: