[DNM] Fix codegen templates and generate additional upstream events#1895
Draft
bidetofevil wants to merge 1 commit into
Draft
[DNM] Fix codegen templates and generate additional upstream events#1895bidetofevil wants to merge 1 commit into
bidetofevil wants to merge 1 commit into
Conversation
2b8c285 to
cc35598
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 64.89% 64.84% -0.05%
==========================================
Files 168 168
Lines 3723 3718 -5
Branches 390 390
==========================================
- Hits 2416 2411 -5
Misses 1194 1194
Partials 113 113 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cc35598 to
eb9cbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate classes for upstream events so they we can use the Java
Loggerinterface instead. As well, there was an issue processing attributes upstream that should be enum and arrays.These are put on two separate commits so they can be diff'd separately.