add build-time android.util.Log call-site substitutions#911
Conversation
LikeTheSalad
left a comment
LikeTheSalad
left a comment
There was a problem hiding this comment.
Thanks! This is a great start.
|
|
||
| public class AndroidLogSubstitutions { | ||
|
|
||
| public static String TAG_KEY = "android.tag"; |
There was a problem hiding this comment.
Actually, the guidance is more to use the AttributeKey class, because avoids having to make a new AttributeKey each time (like the pure string version does).
| public static String TAG_KEY = "android.tag"; | |
| public final static AttributeKey<String> TAG_KEY = AttributeKey.stringKey("android.tag"); |
|
Along with our goal of having READMEs for each instrumentation that describe the telemetry they omit, I think we should include a README in this PR. Thanks! |
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
This is looking good, @cleverchuk thanks for the submission! I'd like us to reference the semconv before merging, and I think we should open an issue to convert some of the assertions to use the upstream test utils, which has more expressive type-specific assertsions for the logs classes....but I think we're close. 😎
3 participants
maybe fixes #142