Relax fragment dependency#941
Closed
breedx-splk wants to merge 1 commit into
Closed
Conversation
Member
|
I think the only problem is if any classes that depend on the fragment lib try to be loaded/instantiated. otherwise the app will crash at runtime |
Contributor
|
Feels like some instrumentation, especially ones with special deps, should be pulled into its own module and can thus be not included for folks who don't want it. |
Contributor
|
What remains of this should be handled in #961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the dependency on navigation-fragment to compileOnly for all modules except fragment intsrumentation.
This should prevent a transitive dependency for users who do not use fragments, and doesn't force a newer version on users who might use an older version.
I tried the demo app, and it came up just fine. I believe that this is because the demo-app uses the agent, and the agent includes fragment instrumentation, so it picks up the transitive dependency as normal. It's a little worrying to have references to Fragment classes with a mere
compileOnly(), so we should figure out what our end state should look like.