Move Session Config up#959
Conversation
|
@MdNaushad it looks like tis PR simply moves the I'm not convinced that we should do this -- the session related stuff is currently all grouped together in the |
Yes, it's simply moving the class. If we want to keep SessionConfig inside the session module, I believe may be we can have methods on OtelRumConfig like This way user won't have to add dependency on session module. Let me know your thoughts |
|
@MdNaushad Ok that's cool...we may just want to move the other config(s) into a common place as well. Regardless, you'll need to sign the CLA before we can accept the PR. Thanks so much! |
Unresolved reference: SessionConfig.session/src/main/kotlin/io/opentelemetry/android/session/SessionConfig.ktopentelemetry-androidis built, it doesn't expose thesessionConfigout for the child projects to use.More info :