Remove runtime dep on androidx fragment navigiation from modules that don't strictly need it#961
Merged
breedx-splk merged 2 commits intoApr 29, 2025
Conversation
Contributor
Author
|
Added additional commit that made |
bidetofevil
changed the title
breedx-splk
reviewed
Apr 24, 2025
| fun testActivity() { | ||
| val activity = Activity() | ||
| val name = ScreenNameExtractor.DEFAULT.extract(activity) | ||
| Assertions.assertEquals("Activity", name) |
Contributor
There was a problem hiding this comment.
Please use static imports for these, or ever better, migrate to the fluent assertj assertions: assertThat(name).isEqualTo("Activity").
I know you didn't write these and migrating to kotlin was just part of the cleanup, but it would help here. Thanks!
breedx-splk
reviewed
Apr 24, 2025
breedx-splk
approved these changes
Apr 24, 2025
marandaneto
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove runtime dependency by looking at whether the fragment is a
NavHost, which is not part of thenavigation-fragmentpackage. We are still depending on AndroidX's Navigation API because that's what the logic checks. Further decoupling will require the implementation to not know about the concept ofNavHost, which will be trickier to do and out of scope for what I'm trying to achieve, i.e. remove the dep to the fragments navigation package only.