refactor(instrumentation): consolidate shared URL helpers into src/utils#272
Open
djvu2k6 wants to merge 14 commits intoopen-telemetry:mainfrom
Open
refactor(instrumentation): consolidate shared URL helpers into src/utils#272djvu2k6 wants to merge 14 commits intoopen-telemetry:mainfrom
djvu2k6 wants to merge 14 commits intoopen-telemetry:mainfrom
Conversation
Implement a default URL sanitization function to redact sensitive information.
Removed the defaultSanitizeUrl function and sensitive parameters list from utils.ts.
Removed documentation for the default URL sanitization function.
Contributor
The instrumentations are experimental and even the export paths state that. ref: https://www.npmjs.com/package/@opentelemetry/browser-instrumentation So I think it's okay to remove the re-export. cc: @open-telemetry/browser-approvers |
Contributor
Author
|
@david-luna Thanks for the clarification! I'll remove the re-export from src/navigation/utils.ts. Since the package is experimental, the breaking change is acceptable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251
Moved
defaultSanitizeUrlfromsrc/navigation/utils.tsto newsrc/utils/url.tsand exported it fromsrc/utils/index.ts.Re-exported from
src/navigation/utils.tsto avoid breaking existing imports.Left
isHashChangein place — navigation-specific, no second consumer found.Surveyed web-vitals, user-action, resource-timing — no additional cross-cutting helpers found.