Skip to content

fix(sdk): use boolean private field and correct repository directory - #315

Merged
overbalance merged 3 commits into
open-telemetry:mainfrom
embrace-io:overbalance/fix-sdk-package-json
Jun 12, 2026
Merged

fix(sdk): use boolean private field and correct repository directory#315
overbalance merged 3 commits into
open-telemetry:mainfrom
embrace-io:overbalance/fix-sdk-package-json

Conversation

@overbalance

@overbalance overbalance commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

The packages/sdk/package.json added in #288 has two metadata mistakes and one inconsistency:

  • private is set to the string "true" instead of the boolean true. npm treats any truthy value as private so publishing is still blocked, but the value does not conform to the package.json schema.
  • repository.directory points to packages/browser, a directory that does not exist in this repository.
  • The exports map lists the root "." entry after the subpath entries.

Short description of the changes

  • Change "private": "true" to "private": true. The package is intentionally kept private for now; publishConfig is left in place for when it is ready to publish.
  • Change repository.directory from packages/browser to packages/sdk.
  • Reorder the exports map so the root "." entry comes first, matching common convention. This is cosmetic; resolution behavior is unchanged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • npm run validate passes (API compliance, web API baseline, package exports/publint, bundle size, module integrity)
  • npm run lint (biome, tsc, eslint) passes via the pre-commit hook

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added (not applicable, metadata-only change)
  • Documentation has been updated (not applicable)

@overbalance
overbalance requested a review from a team as a code owner June 12, 2026 17:57
@overbalance
overbalance enabled auto-merge (squash) June 12, 2026 18:14
@overbalance
overbalance merged commit b2ccb97 into open-telemetry:main Jun 12, 2026
7 checks passed
@overbalance
overbalance deleted the overbalance/fix-sdk-package-json branch June 12, 2026 19:08
@otelbot-browser otelbot-browser Bot mentioned this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants