fix(sdk): use boolean private field and correct repository directory - #315
Merged
overbalance merged 3 commits intoJun 12, 2026
Merged
Conversation
overbalance
enabled auto-merge (squash)
June 12, 2026 18:14
joaquin-diaz
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
packages/sdk/package.jsonadded in #288 has two metadata mistakes and one inconsistency:privateis set to the string"true"instead of the booleantrue. npm treats any truthy value as private so publishing is still blocked, but the value does not conform to the package.json schema.repository.directorypoints topackages/browser, a directory that does not exist in this repository.exportsmap lists the root"."entry after the subpath entries.Short description of the changes
"private": "true"to"private": true. The package is intentionally kept private for now;publishConfigis left in place for when it is ready to publish.repository.directoryfrompackages/browsertopackages/sdk.exportsmap so the root"."entry comes first, matching common convention. This is cosmetic; resolution behavior is unchanged.Type of change
How Has This Been Tested?
npm run validatepasses (API compliance, web API baseline, package exports/publint, bundle size, module integrity)npm run lint(biome, tsc, eslint) passes via the pre-commit hookChecklist: