Skip to content

Commit b4252f7

Browse files
committed
fixup
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
1 parent bd48c47 commit b4252f7

11 files changed

Lines changed: 16 additions & 16 deletions

File tree

extensions/apmint/apmint.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ type apmProcessStorage struct {
5151
TraceSocketPath string
5252
}
5353

54-
// Loader implements plugins.Loader.
54+
// Loader implements extensions.Loader.
5555
func Loader(_ extensions.EbpfHandler, info *extensions.LoaderInfo) (extensions.Data, error) {
5656
if !isPotentialAgentLib(info.FileName()) {
5757
return nil, nil
@@ -158,7 +158,7 @@ type Instance struct {
158158

159159
var _ extensions.Instance = &Instance{}
160160

161-
// Detach implements the plugins.Instance interface.
161+
// Detach implements the extensions.Instance interface.
162162
func (i *Instance) Detach(ebpf extensions.EbpfHandler, pid libpf.PID) error {
163163
return ebpf.DeleteProcData(libpf.APMInt, pid)
164164
}

extensions/config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ type BEAMConfig struct {
6767
}
6868

6969
// ExtensionsConfig holds configuration for all extensions.
70-
// Zero value means all plugins enabled.
70+
// By default all extensions are enabled.
7171
type ExtensionsConfig struct {
7272
Python PythonConfig `mapstructure:"python"`
7373
Perl PerlConfig `mapstructure:"perl"`
@@ -81,5 +81,5 @@ type ExtensionsConfig struct {
8181
BEAM BEAMConfig `mapstructure:"beam"`
8282
}
8383

84-
// AllExtensionsConfig returns a ExtensionsConfig with all extensions enabled (zero value).
84+
// AllExtensionsConfig returns a ExtensionsConfig with all extensions enabled.
8585
func AllExtensionsConfig() ExtensionsConfig { return ExtensionsConfig{} }

extensions/golabels/golabels.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func Loader(_ extensions.EbpfHandler, info *extensions.LoaderInfo) (extensions.D
6363
return nil, nil
6464
}
6565

66-
// Go plugins are shared objects that share the runtime with the main
66+
// Go extensions are shared objects that share the runtime with the main
6767
// binary. The offsets we need are determined by the main binary so
6868
// there is no reason to create a duplicate golabels instance for
6969
// a plugin. A shared library is ET_DYN without a PT_INTERP segment

extensions/nodev8/v8.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ package nodev8 // import "go.opentelemetry.io/ebpf-profiler/extensions/nodev8"
6565
// | as ScopeInfo (normal case), it contains the file name, and the
6666
// | location of this scope along with other details.
6767
// |- function_data
68-
// | can be BytecodeArray, plugins.Data, UncompiledFunctionData, WASM data etc.
68+
// | can be BytecodeArray, extensions.Data, UncompiledFunctionData, WASM data etc.
6969
// \- script_or_debug_info
7070
// as Script, it contains the text source code
7171
// as DebugInfo, there is also debug info available
@@ -200,7 +200,7 @@ const (
200200
// value to avoid huge malloc that could cause OOM crash.
201201
maximumFixedTableSize = 512 * 1024
202202

203-
// lruSourceFileCacheSize is the LRU size for caching source files for an plugins.
203+
// lruSourceFileCacheSize is the LRU size for caching source files for a extension.
204204
// This should reflect the number of hot source files that are seen often in a trace.
205205
lruSourceFileCacheSize = 128
206206

extensions/nodev8/v8_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package nodev8 // import "go.opentelemetry.io/ebpf-profiler/plugins/nodev8"
4+
package nodev8 // import "go.opentelemetry.io/ebpf-profiler/extensions/nodev8"
55

66
import (
77
"testing"

extensions/perl/instance.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ func (i *perlInstance) getGV(gvAddr libpf.Address, nameOnly bool) (libpf.String,
347347
return value, nil
348348
}
349349

350-
// getCOP reads and caches a Control OP from remote plugins.
350+
// getCOP reads and caches a Control OP from remote extensions.
351351
// On success, the COP is returned. On error, the error.
352352
func (i *perlInstance) getCOP(copAddr libpf.Address, funcName libpf.String) (
353353
*perlCOP, error,

extensions/php/opcache.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ package php // import "go.opentelemetry.io/ebpf-profiler/extensions/php"
3232
//
3333
// Before we begin it's illustrative to understand how PHP works internally.
3434
// PHP belongs to the class of interpreted languages that use bytecode: each PHP function is
35-
// decomposed into a sequence of bytecode instructions that are then executed by the PHP plugins.
35+
// decomposed into a sequence of bytecode instructions that are then executed by the PHP extension.
3636
// These instructions are known as zend_ops in the Zend compiler, and their internal structure
3737
// looks like this:
3838
// struct _zend_op {
@@ -81,7 +81,7 @@ package php // import "go.opentelemetry.io/ebpf-profiler/extensions/php"
8181
// The implication of this are:
8282
// a) JIT'd code lives in shared memory, which means that all of the process-local work that the host-agent normally does doesn't really apply for PHP.
8383
// b) The PHP JIT doesn't even live in the same shared object as the PHP interpreter, so we can't
84-
// find the JIT information from the PHP plugins.
84+
// find the JIT information from the PHP extension.
8585
// c) Even if we could, PHP hides symbols by default and so recovering the relevant information isn't easy in this form[2].
8686
//
8787
// Note that we also can't use the approach used in the V8 interpreter

extensions/ruby/ruby.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ type rubyData struct {
138138

139139
// Address to global symbols, for id to string mappings
140140
globalSymbolsAddr libpf.Address
141-
// version of the currently used Ruby plugins.
141+
// version of the currently used Ruby extension.
142142
// major*0x10000 + minor*0x100 + release (e.g. 3.0.1 -> 0x30001)
143143
version uint32
144144

extensions/ruby/ruby_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package ruby // import "go.opentelemetry.io/ebpf-profiler/plugins/ruby"
4+
package ruby // import "go.opentelemetry.io/ebpf-profiler/extensions/ruby"
55

66
import (
77
"testing"

extensions/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import (
1919
)
2020

2121
const (
22-
// LruFunctionCacheSize is the LRU size for caching functions for an plugins.
22+
// LruFunctionCacheSize is the LRU size for caching functions for a extension.
2323
// This should reflect the number of hot functions that are seen often in a trace.
2424
LruFunctionCacheSize = 1024
2525
)

0 commit comments

Comments
 (0)