extensions: rename tracers#1392
Conversation
Implement the idea shared in open-telemetry#1388 (comment). Overall, rename package `interpreter` to `plugins` and promote a plugin specific configuration. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
I'm not sure about this, |
Ah forgot this. But we've now seen that tying the name to Agreeably it does create jitter. But I wonder if it would be still helpful in the long term to reduce confusion on the intended usage. Potential other names for the feature flag / plugin tree: |
|
I just picked If |
|
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Updated the PR to rename |
|
I reckon extensions:
bearertoken:
receivers:
profiling:
extensions:
go:I will give it a though on other alternatives. |
|
Here are some alternatives:
All of them sound good to me and I don't have a preference. Please let me know, which one you prefer. |
|
Why do we need a generic name for different features? My understanding is that symbolization does make sense without a tracer/interpreter, thus it should be a configuration option within the tracer. The idea would be having a custom configuration for each tracer/interpreter. For example: profiling:
tracer:
go:
enabled: true
labels: true
native:
enabled: true
symbolization:
enabled: true
lru_symbols: 1234 |
To stick with the Go example, there is no Go unwinder as Go is handled as part of native unwinding. And by design, native unwinding is always enabled not can not be configured. Thinking about other current "interpreter" like But I also support the idea of extending the per "interpreter" configuration, as what this proposal already does, and make it configurable for the use to enable/disable certain features, like symbolization or the size of their internal caches. |
|
@christos68k && @fabled :
|
Implement the idea shared in #1388 (comment).
Overall, rename package
interpretertoextensionsand promote a extension specific configuration.The respective receiver config part would looks like this: