WIP: Replace otel_scope_info metric with labels in all metrics#6760
Closed
ArthurSens wants to merge 1 commit into
Closed
WIP: Replace otel_scope_info metric with labels in all metrics#6760ArthurSens wants to merge 1 commit into
ArthurSens wants to merge 1 commit into
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Member
|
How this PR compares to #5947? |
Member
|
Wouldn't removing See: |
Member
Author
|
Oh apologies, I didn't notice you already had opened a PR. I'm away from keyboard at the moment, once I'm back I'll close this one and focus on Prometheus receiver/exporter in the collector. Do you need reviews in your PR? |
Member
This would be very helpful. |
Member
Author
|
Closing in favor of #5947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Work in Progress PR to address the specification change outlined in open-telemetry/opentelemetry-specification#4223.
The change is quite small, but there are some open questions from my side:
WithoutScopeInfo? Should this option prevent the label addition?TestIncompatibleMeterNamestill valid? I have the impression it is only asserting thatotel_scope_infois created correctly... so maybe we are better off deleting the test?